fix(spec+compiler): update MCP gateway OTLP headers to string-only (v1.13.0)#25135
fix(spec+compiler): update MCP gateway OTLP headers to string-only (v1.13.0)#25135
Conversation
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/3996a176-e590-4a9b-a928-05c51894409e Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@lpcox FYI |
|
@copilot update compiler to emit string with headers value and NOT try to parse them to a JSON object. |
…sion Agent-Logs-Url: https://github.com/github/gh-aw/sessions/6920f518-5ec9-4aa2-b777-42c0b5b9c02d Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Done in commit 58c4131. The compiler ( Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot merge main and recompile |
…teway-specification Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Done in commit c537fa3. Merged main and recompiled all 182 workflows. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Summary
Updates the MCP Gateway Specification, JSON schemas, and compiler so that the
headersfield in theopentelemetryconfiguration is exclusively a string, removing the previously supported object form. The compiler no longer converts the headers string to a JSON object — the raw string value is passed through directly.Changes
Specification (
docs/src/content/docs/reference/mcp-gateway.md)1.12.0→1.13.0headerstype fromobject | stringtostring; updated description to clarify the value is passed through as-isheadersMUST be a string when provided; removed string-parsing requirementT-OTEL-001 through T-OTEL-012→T-OTEL-001 through T-OTEL-010headerswith string formJSON Schemas
pkg/workflow/schemas/mcp-gateway-config.schema.jsondocs/public/schemas/mcp-gateway-config.schema.jsonBoth: changed
opentelemetryConfig.headersfromoneOf [object, string]to plainstringtype with updated description.Compiler (
pkg/workflow/mcp_renderer.go)OTEL_EXPORTER_OTLP_HEADERSfromkey=value,...format into a JSON object (_GH_AW_OTLP_HEADERS_JSON)"headers": "${OTEL_EXPORTER_OTLP_HEADERS}"— a JSON string value that bash expands at runtime — instead of the previously injected JSON object