Skip to content

Commit f876a56

Browse files
geroplona-agent
andauthored
devcontainer: download pup binary instead of go install (#21360)
pup v0.4.0 (2017) fails to compile with modern Go versions. Download the pre-built binary from GitHub releases instead, matching the approach already used in dev/image/Dockerfile. Co-authored-by: Ona <no-reply@ona.com>
1 parent 52a17d9 commit f876a56

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

.devcontainer/Dockerfile

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,10 @@ RUN curl -fsSLO https://github.com/brancz/gojsontoyaml/releases/download/v${GOJS
242242

243243
# So we can parse the report.html output by leeway, and remove the output produced by this image build
244244
# why? it's too verbose, exceeding the Github Actions summary limit
245-
RUN go install github.com/ericchiang/pup@v0.4.0
245+
RUN curl -fsSL https://github.com/ericchiang/pup/releases/download/v0.4.0/pup_v0.4.0_linux_${TARGETARCH}.zip -o /tmp/pup.zip \
246+
&& unzip -o /tmp/pup.zip -d /usr/local/bin \
247+
&& chmod +x /usr/local/bin/pup \
248+
&& rm /tmp/pup.zip
246249

247250
# Install oci-tool
248251
RUN curl -fsSL https://github.com/csweichel/oci-tool/releases/download/v0.2.0/oci-tool_0.2.0_linux_${TARGETARCH}.tar.gz | tar xz -C /usr/local/bin \

0 commit comments

Comments
 (0)