Show hash/URL of attachments when editing

[bilogic]

Gitea Version

1.27.1

What happened?

1. While editing a comment, I want to remove an attachment, but I can't make out which one it is because the actual URL is not shown when hovered, they are all the same .../issue/6/# or javascript:undefined
2. For some reason, previews also not shown
3. Would be good if the hash or actual URL can be shown, then I can compare in my markdown and remove the right one

How are you running Gitea?

Docker

[aryamohammadi]

The javascript:undefined href is broken regardless of the URL-display request in the title, so I'll open a PR scoped to just that fix.

@bilogic is the missing preview happening for all attachment types, or only some? That may be a separate issue.

[bilogic]

Preview while editing seems to be always broken, but I'm not bothered by it, yes it is a separate issue, I mentioned because it could have help me decide which attachment to remove

[aryamohammadi]

@bilogic Could you assign this issue to me? I’ll work on the javascript:undefined href fix.

[bilogic]

i can't assign, not owner

[aryamohammadi]

@bilogic Hey I have completed the issue. I've posted a pr for it.

[GrigorTonikyan]

@bilogic , this bothered me so I submitted PR which fixes it. Hope it will be reviewed and approved soon.

[bilogic]

@GrigorTonikyan thanks it was bothering me too, that's why I opened this issue

[wxiaoguang]

#39203 is ready for review.

It also fixes the isImageFile regression caused by #30513 which stopped the preview image from showing. That's why there are blanks on your screenshot .....

[bilogic]

let's go!