Skip to content

Commit c3b9e9c

Browse files
committed
Fix lint issues
1 parent 16e22c9 commit c3b9e9c

6 files changed

Lines changed: 14 additions & 11 deletions

File tree

.github/workflows/test.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ jobs:
4040
- name: Run lint
4141
uses: golangci/golangci-lint-action@v9
4242
with:
43-
version: v2.11
43+
version: v2.12
4444
args: --timeout 5m
4545

4646
govulncheck:
@@ -49,3 +49,5 @@ jobs:
4949
steps:
5050
- id: govulncheck
5151
uses: golang/govulncheck-action@v1
52+
with:
53+
go-version-input: 1.26.4

auth/basic.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ func (a *BasicAuthenticator[T]) Authenticate(request *goyave.Request) (*T, error
6969
}
7070

7171
t := reflect.Indirect(reflect.ValueOf(user))
72-
for t.Kind() == reflect.Ptr {
72+
for t.Kind() == reflect.Pointer {
7373
t = t.Elem()
7474
}
7575
pass := t.FieldByName(a.PasswordField)

auth/jwt_controller.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ func (c *JWTController[T]) Login(response *goyave.Response, request *goyave.Requ
122122
}
123123

124124
t := reflect.Indirect(reflect.ValueOf(user))
125-
for t.Kind() == reflect.Ptr {
125+
for t.Kind() == reflect.Pointer {
126126
t = t.Elem()
127127
}
128128
pass := t.FieldByName(c.PasswordField)

config/config_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -746,15 +746,15 @@ func TestRequiredConfig(t *testing.T) {
746746
var nilPointer *string
747747
loader.register("testCategory.nilPointerRequired", Entry{
748748
Value: nilPointer,
749-
Type: reflect.Ptr,
749+
Type: reflect.Pointer,
750750
Required: true,
751751
})
752752

753753
validPointer := new(string)
754754
*validPointer = "valid"
755755
loader.register("testCategory.validPointer", Entry{
756756
Value: validPointer,
757-
Type: reflect.Ptr,
757+
Type: reflect.Pointer,
758758
Required: true,
759759
})
760760

middleware.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ package goyave
22

33
import (
44
"net/http"
5+
"slices"
56
"strings"
67

78
"gorm.io/gorm"
@@ -25,8 +26,8 @@ type middlewareHolder struct {
2526
}
2627

2728
func (h *middlewareHolder) applyMiddleware(handler Handler) Handler {
28-
for i := len(h.middleware) - 1; i >= 0; i-- {
29-
handler = h.middleware[i].Handle(handler)
29+
for _, v := range slices.Backward(h.middleware) {
30+
handler = v.Handle(handler)
3031
}
3132
return handler
3233
}

route.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -294,14 +294,14 @@ func (r *Route) GetFullURIAndParameters() (string, []string) {
294294
segments = append(segments, r.uri)
295295

296296
parameters := make([]string, 0, len(r.parameters))
297-
for i := len(r.parameters) - 1; i >= 0; i-- {
298-
parameters = append(parameters, r.parameters[i])
297+
for _, v := range slices.Backward(r.parameters) {
298+
parameters = append(parameters, v)
299299
}
300300

301301
for router != nil {
302302
segments = append(segments, router.prefix)
303-
for i := len(router.parameters) - 1; i >= 0; i-- {
304-
parameters = append(parameters, router.parameters[i])
303+
for _, v := range slices.Backward(router.parameters) {
304+
parameters = append(parameters, v)
305305
}
306306
router = router.parent
307307
}

0 commit comments

Comments
 (0)