Fix duplicate path join in OS filesystem utility

Author: fnoopv

util/fsutil/osfs/osfs.go

@@ -72,15 +72,15 @@ func (*FS) Getwd() (string, error) {
 // FileExists returns true if the file at the given path exists and is readable.
 // Returns false if the given file is a directory.
 func (f *FS) FileExists(name string) bool {
-	if stats, err := f.Stat(path.Join(f.dir, name)); err == nil {
+	if stats, err := f.Stat(name); err == nil {
 		return !stats.IsDir()
 	}
 	return false
 }
 
 // IsDirectory returns true if the file at the given path exists, is a directory and is readable.
 func (f *FS) IsDirectory(name string) bool {
-	if stats, err := f.Stat(path.Join(f.dir, name)); err == nil {
+	if stats, err := f.Stat(name); err == nil {
 		return stats.IsDir()
 	}
 	return false

util/fsutil/osfs/osfs_test.go

@@ -99,13 +99,27 @@ func TestOSFS(t *testing.T) {
 		assert.False(t, fs.FileExists("resources/notafile.txt"))
 	})
 
+	t.Run("FileExistsWithBaseDir", func(t *testing.T) {
+		fs := New("resources")
+		assert.True(t, fs.FileExists("test_file.txt"))
+		assert.False(t, fs.FileExists("lang"))
+		assert.False(t, fs.FileExists("notafile.txt"))
+	})
+
 	t.Run("IsDirectory", func(t *testing.T) {
 		fs := &FS{}
 		assert.False(t, fs.IsDirectory("resources/test_file.txt"))
 		assert.True(t, fs.IsDirectory("resources"))
 		assert.False(t, fs.IsDirectory("resources/notadir"))
 	})
 
+	t.Run("IsDirectoryWithBaseDir", func(t *testing.T) {
+		fs := New("resources")
+		assert.False(t, fs.IsDirectory("test_file.txt"))
+		assert.True(t, fs.IsDirectory("lang"))
+		assert.False(t, fs.IsDirectory("notadir"))
+	})
+
 	t.Run("Mkdir", func(t *testing.T) {
 		fs := &FS{}
 		path := "resources/testdir"