Skip to content

null Url in repo list can cause crash. #2844

Description

@Nareese

Somehow, a user managed to get "null" in for a repo Url, and this caused a repeatable crash every time they tried to switch to the experimental tab of the settings. Tag for @Aireil riel to fix, per request.

      {
        "$type": "Dalamud.Configuration.ThirdPartyRepoSettings, Dalamud",
        "Url": null,
        "IsEnabled": false
      },
Call Stack
{
  [0]	cimgui.dll+167DD	(igCustom_WindowSetInheritNoInputs+0x1EED)
  [1]	cimgui.dll+39E6	(igPushID_StrStr+0x86)
  [2]	Dalamud.Interface.Utility.Raii.ImRaii+IdDisposable.Push(Dalamud.Bindings.ImGui.ImU8String, Boolean)
  [3]	Dalamud.Interface.Internal.Windows.Settings.Widgets.ThirdRepoSettingsEntry.Draw()
  [4]	Dalamud.Interface.Internal.Windows.Settings.SettingsTab.Draw()
  [5]	Dalamud.Interface.Internal.Windows.Settings.Tabs.SettingsTabExperimental.Draw()
  [6]	Dalamud.Interface.Internal.Windows.Settings.SettingsWindow.DrawTabs()
  [7]	Dalamud.Interface.Internal.Windows.Settings.SettingsWindow.Draw()
  [8]	Dalamud.Interface.Windowing.WindowHost.DrawInternal(WindowDrawParameters, Dalamud.Interface.Windowing.Persistence.WindowSystemPersistence)
  [9]	Dalamud.Interface.Windowing.WindowSystem.Draw()
  [10]	Dalamud.Interface.Internal.DalamudInterface.OnDraw()
  [11]	ILStubClass.IL_STUB_MulticastDelegate_Invoke()
  [12]	Dalamud.Interface.Internal.InterfaceManager.Display()
...

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions