Skip to content

Commit 71e8d75

Browse files
committed
Address review comments
1 parent 97c640c commit 71e8d75

2 files changed

Lines changed: 19 additions & 4 deletions

File tree

ctx.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -405,7 +405,7 @@ func (c *DefaultCtx) Cookie(cookie *Cookie) {
405405
cookie.Expires = time.Time{}
406406
}
407407

408-
var sameSite http.SameSite
408+
sameSite := http.SameSiteLaxMode
409409
switch utils.ToLower(cookie.SameSite) {
410410
case CookieSameSiteStrictMode:
411411
sameSite = http.SameSiteStrictMode
@@ -414,9 +414,7 @@ func (c *DefaultCtx) Cookie(cookie *Cookie) {
414414
case CookieSameSiteDisabled:
415415
sameSite = http.SameSiteDefaultMode
416416
case CookieSameSiteLaxMode:
417-
sameSite = http.SameSiteLaxMode
418-
default:
419-
sameSite = http.SameSiteLaxMode
417+
// already lax
420418
}
421419

422420
hc := &http.Cookie{

ctx_test.go

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -920,6 +920,23 @@ func Test_Ctx_Cookie(t *testing.T) {
920920
require.Equal(t, expect, c.Res().Get(HeaderSetCookie))
921921
}
922922

923+
// go test -run Test_Ctx_Cookie_PartitionedSecure
924+
func Test_Ctx_Cookie_PartitionedSecure(t *testing.T) {
925+
t.Parallel()
926+
app := New()
927+
c := app.AcquireCtx(&fasthttp.RequestCtx{})
928+
929+
ck := &Cookie{
930+
Name: "ps",
931+
Value: "v",
932+
Secure: true,
933+
SameSite: CookieSameSiteNoneMode,
934+
Partitioned: true,
935+
}
936+
c.Res().Cookie(ck)
937+
require.Equal(t, "ps=v; path=/; secure; SameSite=None; Partitioned", c.Res().Get(HeaderSetCookie))
938+
}
939+
923940
// go test -run Test_Ctx_Cookie_Invalid
924941
func Test_Ctx_Cookie_Invalid(t *testing.T) {
925942
t.Parallel()

0 commit comments

Comments
 (0)