Ensure skip flag resets via defer in server error handler

gaby · gaby · commit 810fe692e399 · 2025-11-06T23:53:34.000-05:00
diff --git a/app.go b/app.go
@@ -1329,6 +1329,7 @@ func (app *App) serverErrorHandler(fctx *fasthttp.RequestCtx, err error) {
 
 	if c.getMethodInt() != -1 {
 		c.setSkipNonUseRoutes(true)
+		defer c.setSkipNonUseRoutes(false)
 
 		var nextErr error
 		if d, isDefault := c.(*DefaultCtx); isDefault {
@@ -1340,8 +1341,6 @@ func (app *App) serverErrorHandler(fctx *fasthttp.RequestCtx, err error) {
 		if nextErr != nil && !errors.Is(nextErr, ErrNotFound) && !errors.Is(nextErr, ErrMethodNotAllowed) {
 			log.Errorf("serverErrorHandler: middleware traversal failed: %v", nextErr)
 		}
-
-		c.setSkipNonUseRoutes(false)
 	}
 
 	if catch := app.ErrorHandler(c, err); catch != nil {

Original file line number	Diff line number	Diff line change
`@@ -1329,6 +1329,7 @@ func (app App) serverErrorHandler(fctx fasthttp.RequestCtx, err error) {`
`1329`	`1329`
`1330`	`1330`	`if c.getMethodInt() != -1 {`
`1331`	`1331`	`c.setSkipNonUseRoutes(true)`
	`1332`	`+ defer c.setSkipNonUseRoutes(false)`
`1332`	`1333`
`1333`	`1334`	`var nextErr error`
`1334`	`1335`	`if d, isDefault := c.(*DefaultCtx); isDefault {`
`@@ -1340,8 +1341,6 @@ func (app App) serverErrorHandler(fctx fasthttp.RequestCtx, err error) {`
`1340`	`1341`	`if nextErr != nil && !errors.Is(nextErr, ErrNotFound) && !errors.Is(nextErr, ErrMethodNotAllowed) {`
`1341`	`1342`	`log.Errorf("serverErrorHandler: middleware traversal failed: %v", nextErr)`
`1342`	`1343`	`}`
`1343`		`-`
`1344`		`- c.setSkipNonUseRoutes(false)`
`1345`	`1344`	`}`
`1346`	`1345`
`1347`	`1346`	`if catch := app.ErrorHandler(c, err); catch != nil {`