Merge branch 'main' into 2025-08-21-14-48-18

Author: gaby

.github/workflows/deadcode.yml

@@ -0,0 +1,47 @@
+name: Dead Code (manual)
+
+# Manually-triggered, report-only scan for dead code that the standard `unused`
+# linter cannot catch: unexported symbols referenced only from test files.
+# staticcheck (like golangci-lint's `unused`) counts test references as usage,
+# so this job strips *_test.go and re-runs staticcheck, surfacing test-only
+# symbols as unused (U1000). It never modifies the repo and never posts; the
+# findings are written to the run summary. It does not fail the run, because
+# some flagged symbols may be intentionally test-only (review each by hand).
+
+on:
+  workflow_dispatch:
+
+permissions:
+  contents: read
+
+jobs:
+  deadcode:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
+
+      - name: Set up Go
+        uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6.5.0
+        with:
+          go-version: stable
+
+      - name: Install staticcheck
+        run: go install honnef.co/go/tools/cmd/staticcheck@latest
+
+      - name: Detect test-only dead code (report only)
+        run: |
+          work="$(mktemp -d)"
+          rsync -a --exclude='.git' ./ "$work/"
+          find "$work" -name '*_test.go' -delete
+          cd "$work"
+          {
+            echo "## Dead code report (test-only / unused)"
+            echo
+            echo "Unexported symbols unused once test files are removed."
+            echo "Some may be intentional test-only helpers; review each by hand."
+            echo
+            echo '```'
+          } >> "$GITHUB_STEP_SUMMARY"
+          staticcheck -checks=U1000 ./... 2>&1 | tee -a "$GITHUB_STEP_SUMMARY" || true
+          echo '```' >> "$GITHUB_STEP_SUMMARY"

.github/workflows/release-drafter.yml

@@ -21,4 +21,4 @@ jobs:
     runs-on: ubuntu-latest
     timeout-minutes: 10
     steps:
-      - uses: release-drafter/release-drafter@ed4bc48ec97379be2258e7b7ac2624a3e26ab809 # v7
+      - uses: release-drafter/release-drafter@73b95fa1c286dfd6802a4f949b07dad6149f2b0f # v7

client/core.go

@@ -7,10 +7,7 @@ import (
 	"context"
 	"errors"
 	"fmt"
-	"net"
 	"slices"
-	"strconv"
-	"strings"
 	"sync"
 
 	"github.com/valyala/fasthttp"
@@ -33,19 +30,6 @@ type ResponseHook func(*Client, *Response, *Request) error
 // RetryConfig is an alias for the `retry.Config` type from the `addon/retry` package.
 type RetryConfig = retry.Config
 
-// addMissingPort appends the appropriate port number to the given address if it doesn't have one.
-// If isTLS is true, it uses port 443; otherwise, it uses port 80.
-func addMissingPort(addr string, isTLS bool) string { //revive:disable-line:flag-parameter
-	if strings.IndexByte(addr, ':') != -1 {
-		return addr
-	}
-	port := 80
-	if isTLS {
-		port = 443
-	}
-	return net.JoinHostPort(addr, strconv.Itoa(port))
-}
-
 // core stores middleware and plugin definitions and defines the request execution process.
 type core struct {
 	client *Client

client/core_test.go

@@ -18,49 +18,6 @@ import (
 	"github.com/gofiber/fiber/v3"
 )
 
-func Test_AddMissing_Port(t *testing.T) {
-	t.Parallel()
-
-	type args struct {
-		addr  string
-		isTLS bool
-	}
-	tests := []struct {
-		name string
-		want string
-		args args
-	}{
-		{
-			name: "do anything",
-			args: args{
-				addr: "example.com:1234",
-			},
-			want: "example.com:1234",
-		},
-		{
-			name: "add 80 port",
-			args: args{
-				addr: "example.com",
-			},
-			want: "example.com:80",
-		},
-		{
-			name: "add 443 port",
-			args: args{
-				addr:  "example.com",
-				isTLS: true,
-			},
-			want: "example.com:443",
-		},
-	}
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			t.Parallel()
-			require.Equal(t, tt.want, addMissingPort(tt.args.addr, tt.args.isTLS))
-		})
-	}
-}
-
 func Test_Exec_Func(t *testing.T) {
 	t.Parallel()
 	ln := fasthttputil.NewInmemoryListener()

helpers.go

@@ -219,20 +219,6 @@ func (*App) isASCII(s string) bool {
 	return true
 }
 
-// uniqueRouteStack drop all not unique routes from the slice
-func uniqueRouteStack(stack []*Route) []*Route {
-	m := make(map[*Route]struct{}, len(stack))
-	unique := make([]*Route, 0, len(stack))
-	for _, v := range stack {
-		if _, ok := m[v]; !ok {
-			m[v] = struct{}{}
-			unique = append(unique, v)
-		}
-	}
-
-	return unique
-}
-
 // defaultString returns the value or a default value if it is set
 func defaultString(value string, defaultValue []string) string {
 	if value == "" && len(defaultValue) > 0 {

helpers_test.go

@@ -630,35 +630,6 @@ func Benchmark_Utils_SortAcceptedTypes_Unsorted(b *testing.B) {
 	}, acceptedTypes)
 }
 
-func Test_Utils_UniqueRouteStack(t *testing.T) {
-	t.Parallel()
-	route1 := &Route{}
-	route2 := &Route{}
-	route3 := &Route{}
-	require.Equal(
-		t,
-		[]*Route{
-			route1,
-			route2,
-			route3,
-		},
-		uniqueRouteStack([]*Route{
-			route1,
-			route1,
-			route1,
-			route2,
-			route2,
-			route2,
-			route3,
-			route3,
-			route3,
-			route1,
-			route2,
-			route3,
-		}),
-	)
-}
-
 func Test_Utils_getGroupPath(t *testing.T) {
 	t.Parallel()
 	res := getGroupPath("/v1", "/")