Skip to content

Commit e973773

Browse files
committed
Use cvdr get_config for retrieving service URL from E2E test
1 parent 90e6cbb commit e973773

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

e2etests/cvdr/cvdr_create_with_branch_test.sh

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@ set -e -x
44
source ${TEST_SRCDIR}/_main/cvdr/common_utils.sh
55
validate_components
66

7+
SERVICE=$(cvdr get_config user_default_service || cvdr get_config system_default_service)
8+
SERVICE_URL=$(cvdr get_config "services[\"$SERVICE\"].service_url")
9+
710
HOSTNAME=$(cvdr host create)
811
cleanup() {
912
cvdr host delete ${HOSTNAME}
@@ -19,13 +22,13 @@ cvdr create \
1922
# TODO(b/448209030): cvdr list should print proper ADB connection status.
2023
ACTUAL_OUTPUT=$(cvdr list --host ${HOSTNAME})
2124
EXPECTED_OUTPUT="Host: ${HOSTNAME}
22-
WebUI: http://localhost:8080/v1/zones/local/hosts/${HOSTNAME}/
25+
WebUI: $SERVICE_URL/v1/zones/local/hosts/${HOSTNAME}/
2326
Group: cvd
2427
Instance: 1
2528
Status: Running
2629
ADB: not connected
2730
Displays: [720 x 1280 ( 320 )]
28-
Logs: http://localhost:8080/v1/zones/local/hosts/${HOSTNAME}/cvds/cvd/1/logs/"
31+
Logs: $SERVICE_URL/v1/zones/local/hosts/${HOSTNAME}/cvds/cvd/1/logs/"
2932
diff <(echo ${EXPECTED_OUTPUT}) <(echo ${ACTUAL_OUTPUT})
3033

3134
# Check ADB connection

e2etests/cvdr/cvdr_create_with_local_srcs_test.sh

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@ if [ ! -f "${IMAGE_ZIP}" ]; then
1515
exit 1
1616
fi
1717

18+
SERVICE=$(cvdr get_config user_default_service || cvdr get_config system_default_service)
19+
SERVICE_URL=$(cvdr get_config "services[\"$SERVICE\"].service_url")
20+
1821
HOSTNAME=$(cvdr host create)
1922
cleanup() {
2023
cvdr host delete ${HOSTNAME}
@@ -30,13 +33,13 @@ cvdr create \
3033
# TODO(b/448209030): cvdr list should print proper ADB connection status.
3134
ACTUAL_OUTPUT=$(cvdr list --host ${HOSTNAME})
3235
EXPECTED_OUTPUT="Host: ${HOSTNAME}
33-
WebUI: http://localhost:8080/v1/zones/local/hosts/${HOSTNAME}/
36+
WebUI: $SERVICE_URL/v1/zones/local/hosts/${HOSTNAME}/
3437
Group: cvd_1
3538
Instance: 1
3639
Status: Running
3740
ADB: not connected
3841
Displays: [720 x 1280 ( 320 )]
39-
Logs: http://localhost:8080/v1/zones/local/hosts/${HOSTNAME}/cvds/cvd_1/1/logs/"
42+
Logs: $SERVICE_URL/v1/zones/local/hosts/${HOSTNAME}/cvds/cvd_1/1/logs/"
4043
diff <(echo ${EXPECTED_OUTPUT}) <(echo ${ACTUAL_OUTPUT})
4144

4245
# Check ADB connection

0 commit comments

Comments
 (0)