fix(🐛): Route surfaces configured with viewFormats through the blit path

Added check for viewFormats in swapchain image usage validation.The Vulkan swapchain creates its images without
VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT and wraps them in a texture
descriptor that omits the configuration's viewFormats, so the first
GetCurrentTexture() fails the viewFormats consistency DAWN_CHECK and
aborts. Any non-empty viewFormats now sets needsBlit, like an
unsupported extent or usage: the user-facing texture becomes the
intermediate blit texture, a regular texture created from the full
descriptor, which supports reinterpretation.

Metal already builds the swapchain texture from the full descriptor and
is unaffected. Adds a SurfaceTests end2end case; the file previously
only exercised viewFormatCount = 0, which is why this went unnoticed.

Change-Id: If09df3749bb4de9c9ed011bf924141ea1fbfe15b

Author: wcandillon

src/dawn/native/vulkan/SwapChainVk.cpp

@@ -272,7 +272,10 @@ ResultOrError<SwapChain::Config> SwapChain::ChooseConfig(
     VkImageUsageFlags targetUsages =
         VulkanImageUsage(GetDevice(), GetUsage(), GetDevice()->GetValidInternalFormat(GetFormat()));
     VkImageUsageFlags supportedUsages = surfaceInfo.capabilities.supportedUsageFlags;
-    if (!IsSubset(targetUsages, supportedUsages)) {
+    // The swapchain images are also unable to satisfy viewFormats: they are
+    // created without VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT, so they cannot be
+    // reinterpreted. The blit texture is a regular texture and can.
+    if (!IsSubset(targetUsages, supportedUsages) || !GetViewFormats().empty()) {
         config.needsBlit = true;
     } else {
         config.usage = targetUsages;

src/dawn/tests/end2end/SurfaceTests.cpp

@@ -719,6 +719,34 @@ TEST_P(SurfaceTests, Storage) {
     ASSERT_EQ(wgpu::Status::Success, surface.Present());
 }
 
+// Test acquiring a texture from a surface configured with viewFormats.
+TEST_P(SurfaceTests, ConfigureWithViewFormats) {
+    wgpu::Surface surface = CreateTestSurface();
+    wgpu::SurfaceConfiguration config = GetPreferredConfiguration(surface);
+
+    // Reinterpretation between a format and its srgb counterpart is always
+    // allowed; pick the counterpart of whatever the surface prefers.
+    wgpu::TextureFormat viewFormat;
+    switch (config.format) {
+        case wgpu::TextureFormat::BGRA8Unorm:
+            viewFormat = wgpu::TextureFormat::BGRA8UnormSrgb;
+            break;
+        case wgpu::TextureFormat::RGBA8Unorm:
+            viewFormat = wgpu::TextureFormat::RGBA8UnormSrgb;
+            break;
+        default:
+            GTEST_SKIP() << "Preferred surface format has no srgb counterpart";
+    }
+    config.viewFormatCount = 1;
+    config.viewFormats = &viewFormat;
+    surface.Configure(&config);
+
+    wgpu::SurfaceTexture surfaceTexture;
+    surface.GetCurrentTexture(&surfaceTexture);  // aborts on Vulkan before the fix
+    ClearTexture(surfaceTexture.texture, {1.0, 0.0, 0.0, 1.0});
+    surface.Present();
+}
+
 // TODO(crbug.com/465183957): Implement swap chain for WebGPUBackend.
 DAWN_INSTANTIATE_TEST(SurfaceTests,
                       D3D11Backend(),