Skip to content

Commit a0e93ad

Browse files
author
The Meridian Authors
committed
Rename meridian_max_lag to max_lag in CalibrationBuilder.
PiperOrigin-RevId: 956088344
1 parent 4039b3b commit a0e93ad

3 files changed

Lines changed: 5 additions & 2 deletions

File tree

meridian/constants.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -233,6 +233,7 @@
233233
HILL_BEFORE_ADSTOCK = 'hill_before_adstock'
234234
ADSTOCK_MEMORY_OPTIMIZED = 'adstock_memory_optimized'
235235
MAX_LAG = 'max_lag'
236+
DEFAULT_MAX_LAG = 8
236237
UNIQUE_SIGMA_FOR_EACH_GEO = 'unique_sigma_for_each_geo'
237238
ROI_CALIBRATION_PERIOD = 'roi_calibration_period'
238239
RF_ROI_CALIBRATION_PERIOD = 'rf_roi_calibration_period'

meridian/model/prior_distribution.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1251,7 +1251,9 @@ def distributions_are_equal(
12511251
if isinstance(
12521252
a_params[key], (backend.Tensor, np.ndarray, float, int)
12531253
) and isinstance(b_params[key], (backend.Tensor, np.ndarray, float, int)):
1254-
if not backend.allclose(a_params[key], b_params[key]):
1254+
a_val = backend.cast(a_params[key], backend.float_dtype)
1255+
b_val = backend.cast(b_params[key], backend.float_dtype)
1256+
if not backend.allclose(a_val, b_val):
12551257
return False
12561258
else:
12571259
if np.any(a_params[key] != b_params[key]):

meridian/model/spec.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ class ModelSpec:
234234
)
235235
media_effects_dist: str = constants.MEDIA_EFFECTS_LOG_NORMAL
236236
hill_before_adstock: bool = False
237-
max_lag: int = 8
237+
max_lag: int = constants.DEFAULT_MAX_LAG
238238
unique_sigma_for_each_geo: bool = False
239239
media_prior_type: str | None = None
240240
rf_prior_type: str | None = None

0 commit comments

Comments
 (0)