Merge pull request #270 from philwo/fix-unused-result

robertswiecki · web-flow · commit 1595ebcdf12d · 2026-05-28T22:27:26.000+02:00
unotify: check return value of TextFormat::PrintToString
diff --git a/unotify/stats.cc b/unotify/stats.cc
@@ -170,7 +170,10 @@ void printStats(nsj_t* nsj) {
 	}
 
 	std::string text_report;
-	google::protobuf::TextFormat::PrintToString(report_pb, &text_report);
+	if (!google::protobuf::TextFormat::PrintToString(report_pb, &text_report)) {
+		LOG_W("Failed to format unotify report");
+		return;
+	}
 
 	LOG_I("unotify report:\n%s", text_report.c_str());
 

Original file line number	Diff line number	Diff line change
`@@ -170,7 +170,10 @@ void printStats(nsj_t* nsj) {`
`170`	`170`	`}`
`171`	`171`
`172`	`172`	`std::string text_report;`
`173`		`- google::protobuf::TextFormat::PrintToString(report_pb, &text_report);`
	`173`	`+ if (!google::protobuf::TextFormat::PrintToString(report_pb, &text_report)) {`
	`174`	`+ LOG_W("Failed to format unotify report");`
	`175`	`+ return;`
	`176`	`+ }`
`174`	`177`
`175`	`178`	`LOG_I("unotify report:\n%s", text_report.c_str());`
`176`	`179`