Skip to content

Commit 3ea6dcc

Browse files
committed
build: run nano-init's tests instead of failing to start them
The Makefile exports CGO_ENABLED=0 for the whole file and the root module's test line overrides it to 1, because -race needs cgo. The nano-init line was added without that override, so it inherited 0 and exited immediately with "-race requires cgo". That failure took `make test` with it, which is how it was noticed. The quieter half is that nano-init's tests have not run under `make test` since they were added: the command never got as far as executing them. With the override they run, and pass.
1 parent 333c9bb commit 3ea6dcc

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ kind-e2e-mesh: build
130130

131131
test:
132132
CGO_ENABLED=1 go test -v -race -count 1 $(if $(WHAT),-run $(WHAT)) ./...
133-
go -C cmd/nano-init test -race -count 1 $(if $(WHAT),-run $(WHAT)) ./...
133+
CGO_ENABLED=1 go -C cmd/nano-init test -race -count 1 $(if $(WHAT),-run $(WHAT)) ./...
134134

135135
.PHONY: test-python test-python-e2e
136136
test-python:

0 commit comments

Comments
 (0)