Mounts::AddMappingsForBinary use set for imported_libraries to avoid logspam

Drive-by: cleanup dependencies
PiperOrigin-RevId: 819186220
Change-Id: I4151b09eafe86c83aa1707804b1a2238659f4023

Author: happyCoder92

sandboxed_api/sandbox2/BUILD

@@ -681,6 +681,7 @@ cc_library(
         "//sandboxed_api/util:fileops",
         "//sandboxed_api/util:raw_logging",
         "//sandboxed_api/util:status",
+        "@abseil-cpp//absl/container:flat_hash_set",
         "@abseil-cpp//absl/status",
         "@abseil-cpp//absl/status:statusor",
         "@abseil-cpp//absl/strings",

sandboxed_api/sandbox2/CMakeLists.txt

@@ -643,20 +643,17 @@ add_library(sandbox2_mounts ${SAPI_LIB_TYPE}
 add_library(sandbox2::mounts ALIAS sandbox2_mounts)
 target_link_libraries(sandbox2_mounts
   PRIVATE absl::flat_hash_set
-          absl::str_format
           protobuf::libprotobuf
+          sandbox2::library_resolver
+          sapi::base
           sapi::config
           sapi::file_base
           sapi::fileops
-          sandbox2::minielf
-          sapi::strerror
-          sapi::base
           sapi::raw_logging
           sapi::status
   PUBLIC absl::status
          absl::statusor
          absl::strings
-         sandbox2::library_resolver
          sandbox2::mount_tree_proto
 )
 

sandboxed_api/sandbox2/mounts.cc

@@ -28,6 +28,7 @@
 #include <utility>
 #include <vector>
 
+#include "absl/container/flat_hash_set.h"
 #include "absl/status/status.h"
 #include "absl/status/statusor.h"
 #include "absl/strings/match.h"
@@ -345,14 +346,14 @@ absl::StatusOr<std::string> Mounts::ResolvePath(absl::string_view path) const {
 
 absl::Status Mounts::AddMappingsForBinary(const std::string& path,
                                           absl::string_view ld_library_path) {
-  std::vector<std::string> imported_libraries;
+  absl::flat_hash_set<std::string> imported_libraries;
   SAPI_ASSIGN_OR_RETURN(
       auto interpreter,
       ResolveLibraryPaths(path, ld_library_path, [&](absl::string_view lib) {
-        imported_libraries.push_back(std::string(lib));
+        imported_libraries.insert(std::string(lib));
       }));
   if (!interpreter.empty()) {
-    imported_libraries.push_back(interpreter);
+    imported_libraries.insert(interpreter);
   }
   for (const auto& lib : imported_libraries) {
     SAPI_RETURN_IF_ERROR(AddFile(lib));