clang_generator: Use regular PrintDecl() for array typedefs

Those were already correctly handled before. Added a test for this.

PiperOrigin-RevId: 786185247
Change-Id: I3aa99fdbbdd6ed215a775ab081506bb98a07b492

Author: cblichmann

sandboxed_api/tools/clang_generator/emitter_base.cc

@@ -151,10 +151,11 @@ std::string GetSpelling(const clang::Decl* decl) {
     if (clang::QualType canonical_type =
             typedef_name_decl->getUnderlyingType().getCanonicalType();
         IsPointerOrReference(canonical_type) &&
-        // Need to skip function pointers/refs, as they are correctly emitted
-        // already.
+        // Skip function pointers/refs and array types. For arrays, we need to
+        // check the final underlying pointee type.
         !canonical_type->isFunctionPointerType() &&
-        !canonical_type->isFunctionReferenceType()) {
+        !canonical_type->isFunctionReferenceType() &&
+        !GetFinalPointeeType(canonical_type)->isArrayType()) {
       return absl::StrCat("typedef ", canonical_type.getAsString(),
                           ToStringView(typedef_name_decl->getName()));
     }

sandboxed_api/tools/clang_generator/emitter_test.cc

@@ -493,6 +493,25 @@ TEST_F(EmitterTest, TypedefTypeDependencies) {
                   "struct _Image { StreamHandler stream; int size; }"));
 }
 
+TEST_F(EmitterTest, TypedefArrays) {
+  GeneratorOptions options;
+  EmitterForTesting emitter(&options);
+  EXPECT_THAT(RunFrontendAction(
+                  R"(typedef short JCOEF;
+                     typedef JCOEF JBLOCK[64];
+                     typedef JBLOCK *JBLOCKROW;
+                     typedef JBLOCKROW *JBLOCKARRAY;
+                     extern "C" void Array(JBLOCKARRAY);)",
+                  std::make_unique<GeneratorAction>(&emitter, &options)),
+              IsOk());
+  EXPECT_THAT(emitter.GetRenderedFunctions(), SizeIs(1));
+
+  EXPECT_THAT(UglifyAll(emitter.SpellingsForNS("")),
+              ElementsAre("typedef short JCOEF", "typedef JCOEF JBLOCK[64]",
+                          "typedef JBLOCK *JBLOCKROW",
+                          "typedef JBLOCKROW *JBLOCKARRAY"));
+}
+
 TEST_F(EmitterTest, OmitDependentTypes) {
   GeneratorOptions options;
   EmitterForTesting emitter(&options);

sandboxed_api/tools/clang_generator/types.cc

@@ -34,6 +34,15 @@
 #include "llvm/Support/Casting.h"
 
 namespace sapi {
+
+clang::QualType GetFinalPointeeType(clang::QualType qual) {
+  clang::QualType pointee_type = qual;
+  do {
+    pointee_type = pointee_type->getPointeeType();
+  } while (IsPointerOrReference(pointee_type));
+  return pointee_type;
+}
+
 namespace {
 
 // Checks if a record declaration is a google::protobuf::Message.

sandboxed_api/tools/clang_generator/types.h

@@ -49,6 +49,10 @@ inline bool IsPointerOrReference(clang::QualType qual) {
 #endif
 }
 
+// Returns the final pointee type of a pointer or reference type.
+// For example, for `int**` it returns `int`.
+clang::QualType GetFinalPointeeType(clang::QualType qual);
+
 // RenderedType objects are used to keep track of types that are going to be
 // emitted in the generated header.
 class RenderedType {