Move Sandbox2RPCChannel constructors and destructor out-of-line.

Move the definitions of Sandbox2RPCChannel's constructors and destructor from the header file to the source file so that the unique_ptr destructor knows the size of
the comms class.

PiperOrigin-RevId: 966519206
Change-Id: I65bee2a2f354b6b9d8f78ffd25c30e2270072985

Author: sroettger

sandboxed_api/sandbox2_rpcchannel.cc

@@ -45,6 +45,15 @@
 namespace sapi {
 using sapi::file_util::fileops::FDCloser;
 
+Sandbox2RPCChannel::Sandbox2RPCChannel(sandbox2::Comms* comms, pid_t pid)
+    : comms_(comms), pid_(pid) {}
+
+Sandbox2RPCChannel::Sandbox2RPCChannel(std::unique_ptr<sandbox2::Comms> comms,
+                                       pid_t pid)
+    : owned_comms_(std::move(comms)), comms_(owned_comms_.get()), pid_(pid) {}
+
+Sandbox2RPCChannel::~Sandbox2RPCChannel() = default;
+
 absl::Status Sandbox2RPCChannel::Call(const FuncCall& call, uint32_t tag,
                                       FuncRet* ret, v::Type exp_type) {
   RecursiveMutexLock lock(mutex_);

sandboxed_api/sandbox2_rpcchannel.h

@@ -23,7 +23,6 @@
 #include <cstddef>
 #include <cstdint>
 #include <memory>
-#include <utility>
 
 #include "absl/base/optimization.h"
 #include "absl/base/thread_annotations.h"
@@ -105,8 +104,8 @@ namespace sapi {
 // Comms channel.
 class Sandbox2RPCChannel : public RPCChannel {
  public:
-  explicit Sandbox2RPCChannel(sandbox2::Comms* comms, pid_t pid)
-      : comms_(comms), pid_(pid) {}
+  explicit Sandbox2RPCChannel(sandbox2::Comms* comms, pid_t pid);
+  ~Sandbox2RPCChannel() override;
 
   // Calls a function.
   absl::Status Call(const FuncCall& call, uint32_t tag, FuncRet* ret,
@@ -165,8 +164,8 @@ class Sandbox2RPCChannel : public RPCChannel {
   static constexpr size_t kMaxCallbacks = 64;
   static constexpr size_t kTrampolineSize = 16;
 
-  explicit Sandbox2RPCChannel(std::unique_ptr<sandbox2::Comms> comms, pid_t pid)
-      : owned_comms_(std::move(comms)), comms_(owned_comms_.get()), pid_(pid) {}
+  explicit Sandbox2RPCChannel(std::unique_ptr<sandbox2::Comms> comms,
+                              pid_t pid);
 
   // Marks the memory as initialized (used with MSAN).
   absl::Status MarkMemoryInit(void* addr, size_t size);