Skip to content

Commit a2c3b86

Browse files
committed
chore: address review findings — fix WI-004 title, reword stale fn ref, add tags, and more
- WI-002: reword acceptance criteria to avoid referencing removed count_tag_usage function name - rfcs.md: replace direct version/status --set with rfc bump/finalize - work-items.md: clarify lifecycle fields excluded from direct edit - ADR-0020: tags from ["editing"] to ["collaboration", "work-items"]; register new tags in gov/config.toml - WI-004: fix title to not claim ADR-0016 was superseded; remove normative note paragraph - WI-005: add missing refs = [] field - validation.md: fix "add verb" → "edit command with --add" - CHANGELOG regenerated to reflect WI-002 text change govctl check: ✓ cargo test: 202+all integration tests pass
1 parent 28b064a commit a2c3b86

9 files changed

Lines changed: 15 additions & 12 deletions

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1010
### Added
1111

1212
- tag list loads artifacts once instead of N times (WI-2026-04-21-002)
13-
- tag delete still uses count_tag_usage for safety check — refactored to use batch function too (WI-2026-04-21-002)
13+
- tag delete performs safety check via batch usage map instead of per-tag scan (WI-2026-04-21-002)
1414
- RFC detail view shows tags in header (WI-2026-04-21-003)
1515
- ADR rendered markdown shows tags in metadata (WI-2026-04-21-003)
1616
- Work item rendered markdown shows tags in metadata (WI-2026-04-21-003)

docs/guide/rfcs.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,9 @@ govctl rfc list --tag caching,api
5959
All RFC and clause fields are accessible through path-based editing:
6060

6161
```bash
62-
# Set scalar fields
63-
govctl rfc edit RFC-0010 version --set 1.2.0
64-
govctl rfc edit RFC-0010 status --set normative
62+
# Lifecycle-managed fields use dedicated verbs
63+
govctl rfc bump RFC-0010 --minor -m "Add new clause for edge case"
64+
govctl rfc finalize RFC-0010 normative
6565

6666
# Add to array fields
6767
govctl rfc edit RFC-0010 refs --add RFC-0001

docs/guide/validation.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ govctl tag delete caching
6363

6464
### Tagging Artifacts
6565

66-
Once a tag is registered, apply it to any artifact via the standard `add` verb:
66+
Once a tag is registered, apply it to any artifact via the standard `edit` command with `--add`:
6767

6868
```bash
6969
govctl rfc edit RFC-0010 tags --add caching
@@ -160,7 +160,7 @@ Use `govctl verify` to run guards without moving a work item:
160160
govctl verify
161161

162162
# Run specific guards
163-
govctl verify --guard GUARD-CARGO-TEST --guard GUARD-GOVCTL-CHECK
163+
govctl verify GUARD-CARGO-TEST GUARD-GOVCTL-CHECK
164164

165165
# Run guards required by a specific work item
166166
govctl verify --work WI-2026-01-17-001

docs/guide/work-items.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ The pattern matches case-insensitively by substring.
102102

103103
### Canonical Edit Paths
104104

105-
All work item fields are accessible through the unified path-based edit interface:
105+
Most work item fields are accessible through the unified path-based edit interface. Lifecycle-managed fields (such as `status`) are excluded — use `govctl work move` for status transitions instead.
106106

107107
```bash
108108
# Set scalar fields

gov/adr/ADR-0020-configurable-work-item-id-strategies-for-multi-person-collaboration.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ title = "Configurable work item ID strategies for multi-person collaboration"
66
status = "accepted"
77
date = "2026-01-26"
88
refs = ["RFC-0000"]
9-
tags = ["editing"]
9+
tags = ["collaboration", "work-items"]
1010

1111
[content]
1212
context = """

gov/config.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@ allowed = [
2929
"testing",
3030
"plugin",
3131
"migration",
32+
"collaboration",
33+
"work-items",
3234
]
3335

3436
[verification]

gov/work/2026-04-21-adr-lifecycle-maintenance-supersede-adr-0001-and-adr-0016-fix-cross-references.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
[govctl]
44
id = "WI-2026-04-21-004"
5-
title = "ADR lifecycle maintenance: supersede ADR-0001 and ADR-0016, fix cross-references"
5+
title = "ADR lifecycle maintenance: supersede ADR-0001, fix cross-references"
66
status = "done"
77
created = "2026-04-21"
88
started = "2026-04-21"
@@ -15,12 +15,12 @@ ADR lifecycle maintenance: mark effectively-superseded ADRs and fix missing cros
1515
1616
Outcome:
1717
- ADR-0001: Marked superseded_by = ADR-0034 (TOML format split eliminated by ADR-0034, which extended TOML to all artifacts including RFCs). ADR-0034's decision text explicitly states it supersedes ADR-0001.
18-
- ADR-0016: Kept as accepted. An ADR records why a decision was made; being absorbed into an RFC is success, not obsolescence. RFCs are constitutional law (what must be true), ADRs are justificatory history (why it was chosen). These roles are complementary, not superseding. No schema change needed.
18+
- ADR-0016: Kept as accepted. See ADR-0016 and relevant RFCs for governance semantics.
1919
- ADR-0006: Added ADR-0019 to refs (ADR-0019 reassigned the -n flag from dry-run to limit, partially superseding ADR-0006 on that specific point).
2020
- ADR-0017: Added ADR-0037 to refs (canonical edit command extends the CLI surface defined in ADR-0017).
2121
- src/render.rs: Updated doc comment example and test to use ADR-0042 instead of the now-superseded ADR-0001. Eliminated W0107 warning.
2222
23-
Note: ADR-0016 was kept as accepted because an ADR whose rationale is absorbed into an RFC is not superseded — it has fulfilled its purpose. RFCs and ADRs occupy distinct roles in the governance hierarchy (law vs justification), so cross-type supersession is not a meaningful concept.
23+
2424
"""
2525

2626
[[content.journal]]

gov/work/2026-04-21-document-missing-cli-features-in-user-guide.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ created = "2026-04-21"
88
started = "2026-04-21"
99
completed = "2026-04-21"
1010
tags = ["documentation"]
11+
refs = []
1112

1213
[content]
1314
description = """

gov/work/2026-04-21-optimize-tag-list-performance-batch-load-artifact-tags.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ status = "done"
2525
category = "added"
2626

2727
[[content.acceptance_criteria]]
28-
text = "tag delete still uses count_tag_usage for safety check — refactored to use batch function too"
28+
text = "tag delete performs safety check via batch usage map instead of per-tag scan"
2929
status = "done"
3030
category = "added"
3131

0 commit comments

Comments
 (0)