review the generated unit tests

Author: gpineda-dev

tests/unit/runtime/test_analyzer.py

@@ -154,34 +154,7 @@ def test_analyze_report_ids_reset_cursor():
     assert op2.bit_offset == 0
     assert op2.usage_id == 0x31
 
-def test_analyze_push_pop_items():
-    """Test PUSH and POP items restore global state correctly."""
-    items = [
-        UsagePageItem(GenericDesktop.PAGE_ID), # 0x01
-        PushItem(),
-        
-        UsagePageItem(ButtonPage.PAGE_ID),     # 0x09
-        UsageItem(1),
-        ReportSizeItem(1),
-        ReportCountItem(1),
-        InputItem(0x02),
-        
-        PopItem(),
-        # Should be back to Generic Desktop (0x01)
-        UsageItem(0x30), # X
-        InputItem(0x02)
-    ]
-    descriptor = ReportDescriptor(items)
-    analyzer = DescriptorAnalyzer()
-    layout = analyzer.analyze(descriptor)
-    
-    assert len(layout.fields) == 2
-    
-    btn_op = layout.fields[0]
-    assert btn_op.usage_page == ButtonPage.PAGE_ID
-    
-    desktop_op = layout.fields[1]
-    assert desktop_op.usage_page == GenericDesktop.PAGE_ID
+#TODO more tests for edge cases
 
 def test_analyze_name_collision_handling():
     """Test that duplicate names get suffixed with _2, _3, etc."""

tests/unit/test_loader.py

@@ -158,10 +158,6 @@ def test_parse_source_profile_uri_hex_scheme():
     result = parse_source_profile_uri(uri)
     assert result == b'\x01\x02\x03\x04'
 
-    # Test with 0x prefix and separators (implementation filters non-alnum and removes 0x)
-    uri = "hex://0x01 02,03"
-    result = parse_source_profile_uri(uri)
-    assert result == b'\x01\x02\x03'
 
 def test_parse_source_profile_uri_b64_scheme():
     """Test parsing a b64:// URI returns decoded bytes."""
@@ -172,31 +168,13 @@ def test_parse_source_profile_uri_b64_scheme():
     result = parse_source_profile_uri(uri)
     assert result == data
 
-def test_parse_source_profile_uri_stdin_scheme():
-    """Test parsing stdin:// URI reads from sys.stdin.buffer."""
-    with patch("sys.stdin") as mock_stdin:
-        mock_stdin.isatty.return_value = False
-        mock_stdin.buffer.read.return_value = b'\xAA\xBB'
-        
-        uri = "stdin://"
-        result = parse_source_profile_uri(uri)
-        assert result == b'\xAA\xBB'
 
 def test_parse_source_profile_uri_implicit_hex():
     """Test that a string without scheme is treated as hex."""
     uri = "0A0B0C"
     result = parse_source_profile_uri(uri)
     assert result == b'\x0A\x0B\x0C'
 
-def test_parse_source_profile_uri_implicit_stdin():
-    """Test that '-' is treated as stdin."""
-    with patch("sys.stdin") as mock_stdin:
-        mock_stdin.isatty.return_value = False
-        mock_stdin.buffer.read.return_value = b'\xCC\xDD'
-        
-        uri = "-"
-        result = parse_source_profile_uri(uri)
-        assert result == b'\xCC\xDD'
 
 def test_parse_source_profile_uri_unknown_scheme():
     """Test that an unknown scheme raises ValueError."""

tests/unit/tools/test_monitor.py

@@ -32,18 +32,6 @@ def test_report_event_raw():
     assert d['data'] == "deadbeef"
     assert isinstance(d['timestamp'], float)
 
-def test_report_event_decoded():
-    mock_report = MagicMock(spec=DataBaseReport)
-    mock_report.to_dict.return_value = {"foo": "bar"}
-    
-    event = ReportEvent(data=mock_report)
-    
-    assert event.is_raw() is False
-    assert event.is_decoded() is True
-    assert event.hex() == ""
-    
-    d = event.to_dict()
-    assert d['data'] == {"foo": "bar"}
 
 # --- Tests for HIDMonitor ---
 
@@ -97,22 +85,6 @@ def test_monitor_stream_raw_output():
     assert events[0].data == b'\x01\x02\x03'
     mock_backend.wait_for_data_ready.assert_called()
 
-def test_monitor_stream_decoded_output():
-    mock_backend = MagicMock(spec=DeviceBackend)
-    mock_backend.read.side_effect = [b'\xAA\xBB', b'']
-    
-    mock_codec = MagicMock(spec=HIDCodec)
-    mock_report = MagicMock(spec=DataBaseReport)
-    mock_codec.decode.return_value = mock_report
-    
-    monitor = HIDMonitor(path="dummy", codec=mock_codec, backend=mock_backend)
-    
-    events = list(monitor.stream(raw_output=False))
-    
-    assert len(events) == 1
-    mock_codec.decode.assert_called_once_with(b'\xAA\xBB')
-    assert events[0].is_decoded()
-    assert events[0].data == mock_report
 
 def test_monitor_stream_missing_codec_error():
     mock_backend = MagicMock(spec=DeviceBackend)