dedupe submission creation path

Author: msaroufim

src/kernelbot/api/main.py

@@ -25,7 +25,6 @@
 from libkernelbot.submission import (
     ProcessedSubmissionRequest,
     SubmissionRequest,
-    enforce_gpu_rate_limits,
     prepare_submission,
 )
 from libkernelbot.task import make_task_definition
@@ -504,18 +503,8 @@ async def enqueue_background_job(
     manager: BackgroundSubmissionManager,
 ):
     # pre-create the submission for api returns
+    sub_id = backend.create_submission_record(req, mode)
     with backend.db as db:
-        enforce_gpu_rate_limits(req, db)
-        sub_id = db.create_submission(
-            leaderboard=req.leaderboard,
-            file_name=req.file_name,
-            code=req.code,
-            user_id=req.user_id,
-            time=datetime.datetime.now(datetime.timezone.utc),
-            user_name=req.user_name,
-            mode_category=req.mode_category,
-            requested_gpus=req.gpus,
-        )
         job_id = db.upsert_submission_job_status(sub_id, "initial", None)
     # put submission request in queue
     await manager.enqueue(req, mode, sub_id)

src/libkernelbot/backend.py

@@ -62,6 +62,24 @@ def register_launcher(self, launcher: Launcher):
         for gpu in launcher.gpus:
             self.launcher_map[gpu.value] = launcher
 
+    def create_submission_record(
+        self,
+        req: ProcessedSubmissionRequest,
+        mode: SubmissionMode,
+    ) -> int:
+        with self.db as db:
+            enforce_gpu_rate_limits(req, db)
+            return db.create_submission(
+                leaderboard=req.leaderboard,
+                file_name=req.file_name,
+                code=req.code,
+                user_id=req.user_id,
+                time=datetime.datetime.now(datetime.timezone.utc),
+                user_name=req.user_name,
+                mode_category=req.mode_category or get_mode_category(mode),
+                requested_gpus=req.gpus,
+            )
+
     async def submit_full(
         self,
         req: ProcessedSubmissionRequest,
@@ -77,18 +95,7 @@ async def submit_full(
         if pre_sub_id is not None:
             sub_id = pre_sub_id
         else:
-            with self.db as db:
-                enforce_gpu_rate_limits(req, db)
-                sub_id = db.create_submission(
-                    leaderboard=req.leaderboard,
-                    file_name=req.file_name,
-                    code=req.code,
-                    user_id=req.user_id,
-                    time=datetime.datetime.now(datetime.timezone.utc),
-                    user_name=req.user_name,
-                    mode_category=req.mode_category or get_mode_category(mode),
-                    requested_gpus=req.gpus,
-                )
+            sub_id = self.create_submission_record(req, mode)
         selected_gpus = [get_gpu_by_name(gpu) for gpu in req.gpus]
         submission_started = False
         try: