new codestyle, Phpstan issues

Author: peldax

.github/workflows/php.yml

@@ -20,7 +20,7 @@ jobs:
     - name: Setup PHP
       uses: shivammathur/setup-php@v2
       with:
-        php-version: '8.1'
+        php-version: '8.5'
         ini-values: zend.assertions=1, assert.exception=1
         coverage: xdebug
       env:
@@ -49,7 +49,7 @@ jobs:
     - name: Setup PHP
       uses: shivammathur/setup-php@v2
       with:
-        php-version: '8.1'
+        php-version: '8.5'
         ini-values: zend.assertions=1, assert.exception=1
         coverage: xdebug
       env:
@@ -73,7 +73,7 @@ jobs:
     - name: Setup PHP
       uses: shivammathur/setup-php@v2
       with:
-        php-version: '8.1'
+        php-version: '8.5'
         ini-values: zend.assertions=1, assert.exception=1
       env:
         update: true
@@ -96,7 +96,7 @@ jobs:
       - name: Setup PHP
         uses: shivammathur/setup-php@v2
         with:
-          php-version: '8.1'
+          php-version: '8.5'
         env:
           update: true
 

.gitignore

@@ -1,4 +1,5 @@
 .idea/*
 build/*
 vendor/*
+.phpunit.cache
 .phpunit.result.cache

composer.json

@@ -12,8 +12,8 @@
     }
   ],
   "require": {
-    "php": ">=8.0",
-    "infinityloop-dev/graphpinator-tokenizer": "^1.2",
+    "php": ">=8.1",
+    "infinityloop-dev/graphpinator-tokenizer": "^1.3",
     "infinityloop-dev/graphpinator-common": "^2.0",
     "infinityloop-dev/utils": "^2.0"
   },
@@ -29,8 +29,8 @@
       "Composer\\Config::disableProcessTimeout",
       "infection -j$(nproc)"
     ],
-    "phpstan": "phpstan analyze --level 3 src",
-    "phpstan-next": "phpstan analyze --level 4 src",
+    "phpstan": "phpstan analyze --level max src",
+    "phpstan-next": "phpstan analyze --level max src",
     "phpstan-max": "phpstan analyze --level max src",
     "codestyle": "phpcs --extensions=php src tests",
     "codestyle-fix": "phpcbf --extensions=php src tests"

composer.lock

@@ -0,0 +1,2 @@
+parameters:
+    rememberPossiblyImpureFunctionValues: false

phpstan.neon

@@ -9,6 +9,10 @@
 
 abstract class ParserError extends GraphpinatorBase
 {
+    /**
+     * @param Location $location
+     * @param list<string> $messageArgs
+     */
     public function __construct(
         Location $location,
         array $messageArgs = [],

src/Exception/ParserError.php

@@ -15,6 +15,9 @@ final class FieldSet extends ObjectSet
 {
     protected const INNER_CLASS = Field::class;
 
+    /**
+     * @param list<Field> $fields
+     */
     public function __construct(
         array $fields,
         private FragmentSpreadSet $fragments,

src/Field/FieldSet.php

@@ -16,6 +16,6 @@ final class FragmentSet extends ImplicitObjectMap
 
     protected function getKey(object $object) : string
     {
-        return $object->getName();
+        return $object->getName(); // @phpstan-ignore method.notFound
     }
 }

src/Fragment/FragmentSet.php

@@ -10,8 +10,8 @@
 
 final class Operation
 {
-    private ?VariableSet $variables;
-    private ?DirectiveSet $directives;
+    private VariableSet $variables;
+    private DirectiveSet $directives;
 
     public function __construct(
         private string $type,

src/Operation/Operation.php

@@ -16,7 +16,7 @@ final class OperationSet extends ImplicitObjectMap
 
     protected function getKey(object $object) : string
     {
-        return $object->getName()
+        return $object->getName() // @phpstan-ignore method.notFound
             ?? '';
     }
 }