Add error case tests for usage collector - #8322
Open
jdolle wants to merge 1 commit into
Open
Conversation
Collaborator
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-hive/apollo |
0.48.4-alpha-20260804172259-fad3dc8320490efc9e22822dbd11b24108abac43 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/cli |
0.61.4-alpha-20260804172259-fad3dc8320490efc9e22822dbd11b24108abac43 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/core |
0.22.2-alpha-20260804172259-fad3dc8320490efc9e22822dbd11b24108abac43 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/envelop |
0.40.9-alpha-20260804172259-fad3dc8320490efc9e22822dbd11b24108abac43 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/gateway-plugin-console-sdk |
0.1.2-alpha-20260804172259-fad3dc8320490efc9e22822dbd11b24108abac43 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/yoga |
0.49.2-alpha-20260804172259-fad3dc8320490efc9e22822dbd11b24108abac43 |
npm ↗︎ unpkg ↗︎ |
hive |
11.10.1-alpha-20260804172259-fad3dc8320490efc9e22822dbd11b24108abac43 |
npm ↗︎ unpkg ↗︎ |
Contributor
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tags: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Our collector throws when it encounters unexpected conditions I.e. missing types or fields required to resolve the coordinate.
Description
This PR adds tests to verify this is happening and to document this case.
There is some debate on whether or not this function should throw or handle these cases silently. I believe throwing is still correct because it allows the caller to decide what to do about this case. It's feasible that this function could be used in cases where we don't want to swallow the error.
I believe the recent change to the capture function handles the collector issue correctly and this test is all that we should add.
Checklist