[v18] EKS support in aws_discovery terraform module#65675
Open
charlestp wants to merge 2 commits intobranch/v18from
Open
[v18] EKS support in aws_discovery terraform module#65675charlestp wants to merge 2 commits intobranch/v18from
charlestp wants to merge 2 commits intobranch/v18from
Conversation
Deprecates the flattened singular matcher options in favor of multiple aws_matchers. Thread setup_access_for_arn through discovery terraform
…ws_* fields so we don't have to worry about compatibility. (#65479)
github-actions
bot
requested review from
GavinFrazar,
avatus,
hugoShaka and
marcoandredinis
Contributor
|
Amplify deployment status
|
charlestp
commented
Apr 10, 2026
| teleport = { | ||
| source = "terraform.releases.teleport.dev/gravitational/teleport" | ||
| version = ">= 18.5.1" | ||
| version = ">= 18.7.4" |
Contributor
Author
There was a problem hiding this comment.
Is using the "next release" a bad idea here? This PR includes updates to the teleport provider that I need to use in order to avoid errors from the provider backfilling erroneous ec2 fields into every matcher.
Contributor
There was a problem hiding this comment.
I see no issue with doing that
Contributor
|
#65679 will be backported as a cherry-pick onto this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backfilling #65002 and #65479 into v18.
Changelog: Adds EKS support when using AWS discovery with Terraform.
Manual Test Plan
Test Environment
Cloud staging tenant running v18 dev build (v18.7.4-dev.disceks.7)
Test Cases