Change: Use new /login URL for the login

Requires gsad with greenbone/gsad#403

Author: bjoernricks

src/gmp/__tests__/gmp.test.ts

@@ -35,29 +35,32 @@ describe('Gmp tests', () => {
 
   test('should login user', async () => {
     const token = 'foo';
-    const http = createHttp(createResponse({token}));
+    const http = createHttp(createResponse({token}), {
+      apiServer: 'localhost',
+      apiProtocol: 'http:',
+    });
 
     const storage = createStorage();
     const session = createSession();
     const settings = new Settings(storage);
     const gmp = new Gmp({settings, http, session});
 
     await gmp.login('foo', 'bar');
-    expect(http.request).toHaveBeenCalledWith(
-      'post',
-      expect.objectContaining({
-        data: {
-          cmd: 'login',
-          login: 'foo',
-          password: 'bar',
-        },
-      }),
-    );
+    expect(http.request).toHaveBeenCalledWith('post', {
+      data: {
+        login: 'foo',
+        password: 'bar',
+      },
+      url: 'http://localhost/login',
+    });
     expect(session.login).toHaveBeenCalledWith({token, username: 'foo'});
   });
 
   test('should not login if request fails', async () => {
-    const http = createHttpError(new Error('An error'));
+    const http = createHttpError(new Error('An error'), {
+      apiServer: 'localhost',
+      apiProtocol: 'http:',
+    });
     const storage = createStorage();
     const session = createSession();
     const settings = new Settings(storage);
@@ -66,16 +69,13 @@ describe('Gmp tests', () => {
     try {
       return await gmp.login('foo', 'bar');
     } catch (error) {
-      expect(http.request).toHaveBeenCalledWith(
-        'post',
-        expect.objectContaining({
-          data: {
-            cmd: 'login',
-            login: 'foo',
-            password: 'bar',
-          },
-        }),
-      );
+      expect(http.request).toHaveBeenCalledWith('post', {
+        data: {
+          login: 'foo',
+          password: 'bar',
+        },
+        url: 'http://localhost/login',
+      });
       expect((error as Error).message).toEqual('An error');
       expect(session.login).not.toHaveBeenCalled();
     }

src/gmp/commands/__tests__/login.test.ts

@@ -0,0 +1,44 @@
+/* SPDX-FileCopyrightText: 2024 Greenbone AG
+ *
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+import {describe, test, expect, testing} from '@gsa/testing';
+import LoginCommand from 'gmp/commands/login';
+import {createResponse, createHttp} from 'gmp/commands/testing';
+import {type Envelope} from 'gmp/http/transform/fast-xml';
+import date from 'gmp/models/date';
+
+describe('LoginCommand tests', () => {
+  test('should return Login model on successful login', async () => {
+    testing.useFakeTimers();
+    const response = createResponse<Envelope>({
+      token: 'abc123',
+      timezone: 'UTC',
+      i18n: 'en',
+      session: 3600,
+      jwt: 'jwt_token',
+      client_address: '127.0.0.123',
+    });
+    const fakeHttp = createHttp(response, {
+      apiProtocol: 'https',
+      apiServer: 'example.com',
+    });
+    const cmd = new LoginCommand(fakeHttp);
+    const loginModel = await cmd.login('user', 'pass');
+    expect(fakeHttp.request).toHaveBeenCalledWith('post', {
+      data: {
+        login: 'user',
+        password: 'pass',
+      },
+      url: 'https://example.com/login',
+    });
+    expect(loginModel.token).toEqual('abc123');
+    expect(loginModel.timezone).toEqual('UTC');
+    expect(loginModel.locale).toEqual('en');
+    expect(loginModel.sessionTimeout).toEqual(date('1970-01-01T01:00:00.000Z'));
+    expect(loginModel.jwt).toEqual('jwt_token');
+
+    testing.useRealTimers();
+  });
+});

src/gmp/commands/login.ts

@@ -6,22 +6,30 @@
 import HttpCommand from 'gmp/commands/http';
 import type Http from 'gmp/http/http';
 import {ResponseRejection} from 'gmp/http/rejection';
+import {buildServerUrl} from 'gmp/http/utils';
 import _ from 'gmp/locale';
 import Login from 'gmp/models/login';
 
 class LoginCommand extends HttpCommand {
   constructor(http: Http) {
-    super(http, {
-      cmd: 'login',
-    });
+    super(http);
   }
 
   async login(username: string, password: string) {
     try {
-      const response = await this.httpPostWithTransform({
-        login: username,
-        password,
-      });
+      const response = await this.httpPostWithTransform(
+        {
+          login: username,
+          password,
+        },
+        {
+          url: buildServerUrl(
+            this.http.apiServer,
+            'login',
+            this.http.apiProtocol,
+          ),
+        },
+      );
       return new Login(response);
     } catch (rej) {
       if (rej instanceof ResponseRejection) {