Skip to content

fix: refactor nav bar to be more testable, add unit tests#2540

Open
everettbu wants to merge 2 commits into
masterfrom
aliwaseem/fe-2796-refactor-sidebar-config-and-add-regression-test
Open

fix: refactor nav bar to be more testable, add unit tests#2540
everettbu wants to merge 2 commits into
masterfrom
aliwaseem/fe-2796-refactor-sidebar-config-and-add-regression-test

Conversation

@everettbu

Copy link
Copy Markdown

Mirror of supabase/supabase#43867
Original author: awaseem


I have read the CONTRIBUTING.md file.

YES

What kind of change does this PR introduce?

  • refactor navigation utils to pass in is_platform
  • write unit tests for configuration returns
  • default is always passed from constant IS_PLATFORM

@github-actions

github-actions Bot commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

🎭 Playwright Test Results

passed  158 passed
skipped  5 skipped

Details

stats  163 tests across 20 suites
duration  2 minutes, 54 seconds
commit  a7c7b33

Skipped tests

Features › assistant.spec.ts › AI Assistant › Can send a message to the assistant and receive a response
Features › sql-editor.spec.ts › SQL Editor › snippet favourite works as expected
Features › sql-editor.spec.ts › SQL Editor › share with team works as expected
Features › sql-editor.spec.ts › SQL Editor › folders works as expected
Features › sql-editor.spec.ts › SQL Editor › other SQL snippets actions work as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants