Skip to content

refactor: move /incident-status to app router#2552

Open
everettbu wants to merge 2 commits into
masterfrom
charis/refactor/app-router-incident-status
Open

refactor: move /incident-status to app router#2552
everettbu wants to merge 2 commits into
masterfrom
charis/refactor/app-router-incident-status

Conversation

@everettbu

Copy link
Copy Markdown

Mirror of supabase/supabase#43881
Original author: charislam


I have read the CONTRIBUTING.md file.

YES

What kind of change does this PR introduce?

Refactor

What is the current behavior?

/incident-status is handled via Pages Router.

What is the new behavior?

/incident-status is handled via App Router, enabling use of Vercel Data Cache to cache the upstream fetch.

Additional context

Adding the first App Router route handler triggered next typegen (run as pretypecheck) to generate .next/dev/types/validator.ts, which imports all route files and expanded the type-checked graph. This surfaced pre-existing null-safety errors in:

  • components/grid/SupabaseGrid.utils.tsuseSearchParams() result
  • components/layouts/ProjectLayout/UpgradingState/index.tsxuseSearchParams() result
  • pages/project/[ref]/sql/quickstarts.tsxuseParams() result
  • pages/project/[ref]/sql/templates.tsxuseParams() result

These are fixed with optional chaining. The tsconfig.json change (adding .next/dev/types/**/*.ts to include) is auto-generated by Next.js and committed as correct behavior.

Move /incident-status handler to App Router. Allows us to use Vercel
Data Cache to cache the upstream fetch.
@github-actions

github-actions Bot commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

🎭 Playwright Test Results

failed  1 failed
passed  156 passed
flaky  1 flaky
skipped  5 skipped

Details

stats  163 tests across 20 suites
duration  3 minutes
commit  35ec70d

Failed tests

Features › realtime-inspector.spec.ts › Realtime Inspector › Broadcast Messages › broadcast modal validates JSON payload

Flaky tests

Features › queue-table-operations.spec.ts › Queue Table Operations › pending changes persist when switching between tables

Skipped tests

Features › assistant.spec.ts › AI Assistant › Can send a message to the assistant and receive a response
Features › sql-editor.spec.ts › SQL Editor › snippet favourite works as expected
Features › sql-editor.spec.ts › SQL Editor › share with team works as expected
Features › sql-editor.spec.ts › SQL Editor › folders works as expected
Features › sql-editor.spec.ts › SQL Editor › other SQL snippets actions work as expected

@everettbu everettbu force-pushed the charis/refactor/app-router-incident-status branch from 02b77eb to 35ec70d Compare March 17, 2026 19:28
@blacksmith-sh

blacksmith-sh Bot commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

Found 11 test failures on Blacksmith runners:

Failures

Test View Logs
[Features] › features/
queue-table-operations.spec.ts:422:3 › Queue Table Operations › pending changes persist
when switching between tables
View Logs
[Features] › features/
realtime-inspector.spec.ts:115:5 › Realtime Inspector › Broadcast Messages › broadcast
modal validates JSON payload
View Logs
Queue Table Operations/pending changes persist when switching between tables View Logs
Queue Table Operations/pending changes persist when switching between tables (retry #1) View Logs
Queue Table Operations/pending changes persist when switching between tables (retry #2) View Logs
Realtime Inspector › Broadcast Messages/broadcast modal validates JSON payload View Logs
Realtime Inspector › Broadcast Messages/
broadcast modal validates JSON payload (retry #1)
View Logs
Realtime Inspector › Broadcast Messages/
broadcast modal validates JSON payload (retry #2)
View Logs
Realtime Inspector › Broadcast Messages/
broadcast modal validates JSON payload (retry #3)
View Logs
Realtime Inspector › Broadcast Messages/
broadcast modal validates JSON payload (retry #4)
View Logs
Realtime Inspector › Broadcast Messages/
broadcast modal validates JSON payload (retry #5)
View Logs

Fix in Cursor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants