refactor: move /incident-status to app router#2552
Conversation
Move /incident-status handler to App Router. Allows us to use Vercel Data Cache to cache the upstream fetch.
🎭 Playwright Test Results
Details
Failed testsFeatures › realtime-inspector.spec.ts › Realtime Inspector › Broadcast Messages › broadcast modal validates JSON payload Flaky testsFeatures › queue-table-operations.spec.ts › Queue Table Operations › pending changes persist when switching between tables Skipped testsFeatures › assistant.spec.ts › AI Assistant › Can send a message to the assistant and receive a response |
…ced by App Router typegen
02b77eb to
35ec70d
Compare
|
Found 11 test failures on Blacksmith runners: Failures
|
Mirror of supabase/supabase#43881
Original author: charislam
I have read the CONTRIBUTING.md file.
YES
What kind of change does this PR introduce?
Refactor
What is the current behavior?
/incident-statusis handled via Pages Router.What is the new behavior?
/incident-statusis handled via App Router, enabling use of Vercel Data Cache to cache the upstream fetch.Additional context
Adding the first App Router route handler triggered
next typegen(run aspretypecheck) to generate.next/dev/types/validator.ts, which imports all route files and expanded the type-checked graph. This surfaced pre-existingnull-safety errors in:components/grid/SupabaseGrid.utils.ts—useSearchParams()resultcomponents/layouts/ProjectLayout/UpgradingState/index.tsx—useSearchParams()resultpages/project/[ref]/sql/quickstarts.tsx—useParams()resultpages/project/[ref]/sql/templates.tsx—useParams()resultThese are fixed with optional chaining. The
tsconfig.jsonchange (adding.next/dev/types/**/*.tstoinclude) is auto-generated by Next.js and committed as correct behavior.