[8.3.7] Link color for dark mode not respected

[koelle25]

TL;DR: Dark theme link color not respected in upgraded instance. No problems in a clean install. Don't know where to check for the underlying problem.

After upgrading from 8.3.6 to 8.3.7 and now testing the new light/dark mode.

As there are new settings for the link colors separate for light and dark mode (and no longer using the primary theme color), I set them to my colors of choice. By default they were set to a medium-dark green (light mode) and a light green (dark mode).

In light mode everything works fine.

But switching to dark mode and links stay light green (I tested with #cccccc and #f55500). Tested with cache disabled via F12 developer console and also in a private browser window. I even tested restarting the docker container, but to no avail.

I cannot find any relevant log output. storage/logs/laravel.log actually stays empty, I suspect because of Docker environment logs go directly into the container logs? But there is also nothing relevant. Browser console also has no output.

It just seems the color entered on the settings page doesn't get applied into the generated CSS:

        [data-theme="light"] {
            color-scheme: light;
            /** other settings **/
            --link-color: #f55500;
            --link-hover:  hsl(from var(--link-color) h s calc(l - 10));

        }

        [data-theme="dark"] {
            color-scheme: dark;
             /** other settings **/
            --link-color: #9ACD32;
            --link-hover:  hsl(from var(--link-color) h s calc(l + 15));

        }

I checked against a clean install and there everything is working fine.

I have no idea where to start looking for the problem.

Screenshots

Settings > Branding

Light mode

Dark mode

[sneak-it]

Can confirm - same issue here.

[jamboNum5]

90's vibes, this is a problem for also.

• 90's vibes with the green and grey. This issue is also a problem for me.

[snipe]

How exactly do you think that's helpful?

[jamboNum5]

I was mainly commenting so I would get an update if issue was resolved. The previous comment also said they had the same issue 🤷🏼‍♂️ No offence intended.

I'm on v8.3.7, I have some overrided on mine, but they didn't target a tags. If this is working on a later version is this a cache issue?

[jamboNum5]

Version v8.4.0 has fixed the issue, thank you for confirming.

[snipe]

@koelle25 - do you have any overrides in your Account Settings (not admin settings)? I can't seem to reproduce this on latest.

[sirzerator]

See #18345 (comment) for a solution if upgrading to v8.4.0 does not fix it.