-
Notifications
You must be signed in to change notification settings - Fork 0
Enhance E2E tests to verify bin file executability #363
Copy link
Copy link
Open
Labels
enhancementNew feature or requestNew feature or requestpriority:mediumMedium priorityMedium priorityscope:cliIssues related to the CLI packageIssues related to the CLI packagescope:device-profilerIssues related to the device-profiler packageIssues related to the device-profiler packagescope:emulatorIssues related to the emulator packageIssues related to the emulator packagescope:mqtt-bridgeIssues related to the MQTT bridge packageIssues related to the MQTT bridge packagetestingTesting improvements and additionsTesting improvements and additions
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestpriority:mediumMedium priorityMedium priorityscope:cliIssues related to the CLI packageIssues related to the CLI packagescope:device-profilerIssues related to the device-profiler packageIssues related to the device-profiler packagescope:emulatorIssues related to the emulator packageIssues related to the emulator packagescope:mqtt-bridgeIssues related to the MQTT bridge packageIssues related to the MQTT bridge packagetestingTesting improvements and additionsTesting improvements and additions
Problem
E2E tests currently check that bin files exist but not that they are executable:
This test would pass even if the file has no executable permissions.
Context
node <path>, bypassing executable permissionsya-modbus-emulatordirectly, notnode ya-modbus-emulator.jsProposed Solution
Update E2E tests to check executability instead of just existence:
tests/e2e/tests/02-emulator.bats:
Apply similar changes to:
tests/e2e/tests/03-mqtt-bridge.batstests/e2e/tests/04-cli.batstests/e2e/tests/05-device-profiler.bats(if exists)Benefits
node)Effort
~1 hour (update 3-4 test files)
Related