chore: Running go fix ./... (#6758)

* chore: Running `go fix ./...`

* chore: Addressing lint failures

Author: yhakbar

internal/cli/commands/catalog/tui/keys.go

@@ -178,30 +178,28 @@ func (keys PagerKeyMap) FullHelp() [][]key.Binding {
 // NewPagerKeyMap returns a set of keybindings for the pager view.
 func NewPagerKeyMap() PagerKeyMap {
 	return PagerKeyMap{
-		KeyMap: viewport.KeyMap{
-			HalfPageUp: key.NewBinding(
-				key.WithDisabled(),
-			),
-			HalfPageDown: key.NewBinding(
-				key.WithDisabled(),
-			),
-			Up: key.NewBinding(
-				key.WithKeys("k", "up", "ctrl+p"),
-				key.WithHelp("k/↑", "move up"),
-			),
-			Down: key.NewBinding(
-				key.WithKeys("j", "down", "ctrl+n"),
-				key.WithHelp("j/↓", "move down"),
-			),
-			PageDown: key.NewBinding(
-				key.WithKeys("l", "right", "pgdown", "ctrl+v"),
-				key.WithHelp("l/→", "page down"),
-			),
-			PageUp: key.NewBinding(
-				key.WithKeys("h", "left", "pgup", "alt+v"),
-				key.WithHelp("h/←", "page up"),
-			),
-		},
+		HalfPageUp: key.NewBinding(
+			key.WithDisabled(),
+		),
+		HalfPageDown: key.NewBinding(
+			key.WithDisabled(),
+		),
+		Up: key.NewBinding(
+			key.WithKeys("k", "up", "ctrl+p"),
+			key.WithHelp("k/↑", "move up"),
+		),
+		Down: key.NewBinding(
+			key.WithKeys("j", "down", "ctrl+n"),
+			key.WithHelp("j/↓", "move down"),
+		),
+		PageDown: key.NewBinding(
+			key.WithKeys("l", "right", "pgdown", "ctrl+v"),
+			key.WithHelp("l/→", "page down"),
+		),
+		PageUp: key.NewBinding(
+			key.WithKeys("h", "left", "pgup", "alt+v"),
+			key.WithHelp("h/←", "page up"),
+		),
 		HelpModel: help.New(),
 		Navigation: key.NewBinding(
 			key.WithKeys("tab", "shift+tab"),

internal/cli/commands/catalog/tui/layout.go

@@ -114,8 +114,7 @@ func takeWidthSuffix(s string, maxW int) string {
 
 	w := 0
 
-	for i := len(rs) - 1; i >= 0; i-- {
-		r := rs[i]
+	for _, r := range slices.Backward(rs) {
 		rw := lipgloss.Width(string(r))
 
 		if w+rw > maxW {

internal/cli/commands/stack/stack.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"fmt"
 	"path/filepath"
+	"slices"
 
 	"github.com/gruntwork-io/terragrunt/internal/configbridge"
 	"github.com/gruntwork-io/terragrunt/internal/telemetry"
@@ -213,8 +214,8 @@ func FilterOutputs(outputs cty.Value, index string) (cty.Value, error) {
 		current = next
 	}
 
-	for i := len(segments) - 1; i >= 0; i-- {
-		current = cty.ObjectVal(map[string]cty.Value{segments[i]: current})
+	for _, segment := range slices.Backward(segments) {
+		current = cty.ObjectVal(map[string]cty.Value{segment: current})
 	}
 
 	return current, nil

internal/clihelper/command.go

@@ -278,7 +278,7 @@ func (cmd *Command) flagSetParse(
 
 		for i, arg := range args {
 			// `--var=input=from_env` trims to `var`
-			trimmed := strings.SplitN(strings.Trim(arg, "-"), "=", 2)[0] //nolint:mnd
+			trimmed, _, _ := strings.Cut(strings.Trim(arg, "-"), "=")
 			if trimmed == undefArg {
 				undefArgs = append(undefArgs, arg)
 				notFoundMatch = true

internal/discovery/phase_parse.go

@@ -416,8 +416,7 @@ func parseComponent(
 			)
 			if err != nil {
 				if discovery.suppressParseErrors {
-					var notFoundErr config.TerragruntConfigNotFoundError
-					if errors.As(err, &notFoundErr) {
+					if _, ok := errors.AsType[config.TerragruntConfigNotFoundError](err); ok {
 						l.Debugf(
 							"Skipping missing config during discovery: %s",
 							parseOpts.TerragruntConfigPath,

internal/engine/engine.go

@@ -897,12 +897,10 @@ func createEngine(
 		}
 
 		client := plugin.NewClient(&plugin.ClientConfig{
-			Logger: logger,
-			HandshakeConfig: plugin.HandshakeConfig{
-				ProtocolVersion:  engineVersion,
-				MagicCookieKey:   engineCookieKey,
-				MagicCookieValue: engineCookieValue,
-			},
+			Logger:           logger,
+			ProtocolVersion:  engineVersion,
+			MagicCookieKey:   engineCookieKey,
+			MagicCookieValue: engineCookieValue,
 			Plugins: map[string]plugin.Plugin{
 				"plugin": &engine.TerragruntGRPCEngine{},
 			},

internal/errorconfig/types.go

@@ -132,8 +132,7 @@ func ExtractErrorMessage(err error) string {
 
 	// For ProcessExecutionError, match only against stderr and the underlying error,
 	// not the full command string with flags.
-	var processErr util.ProcessExecutionError
-	if errors.As(err, &processErr) {
+	if processErr, ok := errors.AsType[util.ProcessExecutionError](err); ok {
 		errText = processErr.Output.Stderr.String() + "\n" + processErr.Err.Error()
 	} else {
 		errText = err.Error()

internal/filter/filters.go

@@ -44,8 +44,7 @@ func ParseFilterQueries(l log.Logger, filterStrings []string) (Filters, error) {
 	for i, filterString := range filterStrings {
 		filter, err := Parse(filterString)
 		if err != nil {
-			var parseErr ParseError
-			if errors.As(err, &parseErr) {
+			if parseErr, ok := errors.AsType[ParseError](err); ok {
 				diagnostics = append(diagnostics, FormatDiagnostic(&parseErr, i, useColor))
 
 				continue

internal/getter/oci.go

@@ -775,8 +775,7 @@ func (g *OCIGetter) extractModuleWithLimits(
 
 	err = g.promoteModule(staging, sourcePath, dstPath)
 
-	var restoreErr OCIRestoreError
-	if errors.As(err, &restoreErr) {
+	if _, ok := errors.AsType[OCIRestoreError](err); ok {
 		keepStaging = true
 	}
 

internal/getter/oci_auth_test.go

@@ -6,6 +6,7 @@ import (
 	"encoding/json"
 	"errors"
 	"io"
+	"maps"
 	"path/filepath"
 	"strings"
 	"sync/atomic"
@@ -1213,9 +1214,7 @@ func credentialVenv(home string, extra map[string]string) *venv.Venv {
 // credentialVenvForGOOS builds a hermetic in-memory Venv for goos.
 func credentialVenvForGOOS(goos, home string, extra map[string]string) *venv.Venv {
 	env := map[string]string{}
-	for name, value := range extra {
-		env[name] = value
-	}
+	maps.Copy(env, extra)
 
 	return venvtest.New().
 		WithGOOS(goos).