Skip to content

Commit 247a0d0

Browse files
committed
fix: Addressing shellcheck findings
1 parent 5226c94 commit 247a0d0

2 files changed

Lines changed: 15 additions & 9 deletions

File tree

.github/scripts/release/check-release-exists.sh

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,11 @@ function main {
1919

2020
# Check if release exists using gh CLI (only care about exit code)
2121
if ! gh release view "$VERSION" > /dev/null 2>&1; then
22-
printf 'exists=false\n' >> "$GITHUB_OUTPUT"
23-
printf 'is_draft=false\n' >> "$GITHUB_OUTPUT"
24-
printf 'release_id=\n' >> "$GITHUB_OUTPUT"
22+
{
23+
printf 'exists=false\n'
24+
printf 'is_draft=false\n'
25+
printf 'release_id=\n'
26+
} >>"$GITHUB_OUTPUT"
2527
printf 'Release not found for tag %s\n' "$VERSION"
2628
return 0
2729
fi
@@ -39,10 +41,12 @@ function main {
3941
is_draft=$(jq -r '.isDraft' <<< "$release_json")
4042

4143
# Write to GitHub output
42-
printf 'exists=true\n' >> "$GITHUB_OUTPUT"
43-
printf 'release_id=%s\n' "$release_id" >> "$GITHUB_OUTPUT"
44-
printf 'upload_url=%s\n' "$upload_url" >> "$GITHUB_OUTPUT"
45-
printf 'is_draft=%s\n' "$is_draft" >> "$GITHUB_OUTPUT"
44+
{
45+
printf 'exists=true\n'
46+
printf 'release_id=%s\n' "$release_id"
47+
printf 'upload_url=%s\n' "$upload_url"
48+
printf 'is_draft=%s\n' "$is_draft"
49+
} >>"$GITHUB_OUTPUT"
4650

4751
echo "Found existing release:"
4852
printf ' Release ID: %s\n' "$release_id"

.github/scripts/release/resolve-version-ref.sh

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,10 @@ function main {
5454
ref="$RELEASE_TARGET"
5555
fi
5656

57-
printf 'version=%s\n' "$version" >>"$GITHUB_OUTPUT"
58-
printf 'ref=%s\n' "$ref" >>"$GITHUB_OUTPUT"
57+
{
58+
printf 'version=%s\n' "$version"
59+
printf 'ref=%s\n' "$ref"
60+
} >>"$GITHUB_OUTPUT"
5961
echo "Resolved version: $version, ref: $ref"
6062

6163
return 0

0 commit comments

Comments
 (0)