feat: Discovey false positive parsing errors (#4605)

* Reduced false positive parsing errors

* Simplified discovery errors

* Parsing errors simplification

* Simplified errors printing

* Added test for remote source runner pool

* Tests cleanup

* Added filtering of diagnostic errors containing outputs

* source update

Author: denis256

internal/discovery/discovery.go

@@ -9,6 +9,8 @@ import (
 	"sort"
 	"strings"
 
+	"github.com/gruntwork-io/terragrunt/config/hclparse"
+
 	"github.com/gruntwork-io/terragrunt/internal/experiment"
 	"github.com/gruntwork-io/terragrunt/util"
 
@@ -18,6 +20,7 @@ import (
 	"github.com/gruntwork-io/terragrunt/internal/errors"
 	"github.com/gruntwork-io/terragrunt/options"
 	"github.com/gruntwork-io/terragrunt/pkg/log"
+	"github.com/hashicorp/hcl/v2"
 	"github.com/zclconf/go-cty/cty"
 )
 
@@ -248,6 +251,26 @@ func (c *DiscoveredConfig) Parse(ctx context.Context, l log.Logger, opts *option
 		config.ExcludeBlock,
 	)
 
+	if suppressParseErrors {
+		// If suppressing parse errors, we want to filter diagnostics that contain references to outputs,
+		// while leaving other diagnostics as is.
+		parseOptions := append(parsingCtx.ParserOptions, hclparse.WithDiagnosticsHandler(func(file *hcl.File, hclDiags hcl.Diagnostics) (hcl.Diagnostics, error) {
+			filteredDiags := hcl.Diagnostics{}
+
+			for _, hclDiag := range hclDiags {
+				containsOutputRef := strings.Contains(strings.ToLower(hclDiag.Summary), "output") ||
+					strings.Contains(strings.ToLower(hclDiag.Detail), "output")
+
+				if !containsOutputRef {
+					filteredDiags = append(filteredDiags, hclDiag)
+				}
+			}
+
+			return filteredDiags, nil
+		}))
+		parsingCtx = parsingCtx.WithParseOption(parseOptions)
+	}
+
 	//nolint: contextcheck
 	cfg, err := config.ParseConfigFile(parsingCtx, l, parseOpts.TerragruntConfigPath, nil)
 	if err != nil {

test/fixtures/runner-pool-remote-source/unit-a/terragrunt.hcl

@@ -0,0 +1,3 @@
+terraform {
+    source = "github.com/gruntwork-io/terragrunt.git//test/fixtures/fail-fast/unit-a?ref=v0.84.1"
+}

test/fixtures/runner-pool-remote-source/unit-b/terragrunt.hcl

@@ -0,0 +1,14 @@
+terraform {
+  source = "github.com/gruntwork-io/terragrunt.git//test/fixtures/fail-fast/unit-a?ref=v0.84.1"
+}
+
+dependency "unit-a" {
+  config_path = "../unit-a"
+  mock_outputs = {
+    data = "test-data"
+  }
+}
+
+inputs = {
+  data = dependency.unit-a.outputs.data
+}

test/integration_runner_pool_test.go

@@ -13,8 +13,9 @@ import (
 )
 
 const (
-	testFixtureMixedConfig = "fixtures/mixed-config"
-	testFixtureFailFast    = "fixtures/fail-fast"
+	testFixtureMixedConfig            = "fixtures/mixed-config"
+	testFixtureFailFast               = "fixtures/fail-fast"
+	testFixtureRunnerPoolRemoteSource = "fixtures/runner-pool-remote-source"
 )
 
 func TestRunnerPoolDiscovery(t *testing.T) {
@@ -119,9 +120,13 @@ func TestRunnerPoolDestroyFailFast(t *testing.T) {
 	tmpEnvPath := helpers.CopyEnvironment(t, testFixtureFailFast)
 	testPath := util.JoinPath(tmpEnvPath, testFixtureFailFast)
 
-	_, _, err := helpers.RunTerragruntCommandWithOutput(t, "terragrunt run --all --non-interactive --experiment runner-pool --fail-fast --working-dir "+testPath+"  -- apply")
+	_, stdout, err := helpers.RunTerragruntCommandWithOutput(t, "terragrunt run --all --non-interactive --experiment runner-pool --fail-fast --working-dir "+testPath+"  -- apply")
 	require.NoError(t, err)
 
+	// Verify that there are no parsing errors in the output
+	require.NotContains(t, stdout, "Error: Unsupported block type")
+	require.NotContains(t, stdout, "This object does not have an attribute named \"outputs\"")
+
 	// create fail.txt in unit-a to trigger a failure
 	helpers.CreateFile(t, testPath, "unit-b", "fail.txt")
 	stdout, stderr, _ := helpers.RunTerragruntCommandWithOutput(t, "terragrunt run --all --non-interactive --experiment runner-pool --fail-fast --working-dir "+testPath+"  -- destroy")
@@ -147,3 +152,16 @@ func TestRunnerPoolDestroyDependencies(t *testing.T) {
 	assert.Contains(t, stdout, "unit-a tf-path="+wrappedBinary()+" msg=Destroy complete! Resources: 1 destroyed.")
 
 }
+
+func TestRunnerPoolRemoteSource(t *testing.T) {
+	t.Parallel()
+
+	helpers.CleanupTerraformFolder(t, testFixtureRunnerPoolRemoteSource)
+	tmpEnvPath := helpers.CopyEnvironment(t, testFixtureRunnerPoolRemoteSource)
+	testPath := util.JoinPath(tmpEnvPath, testFixtureRunnerPoolRemoteSource)
+
+	stdout, _, err := helpers.RunTerragruntCommandWithOutput(t, "terragrunt run --all --non-interactive --log-level debug --experiment runner-pool --working-dir "+testPath+"  -- apply")
+	require.NoError(t, err)
+	// Verify that the output contains value produced from remote unit
+	require.Contains(t, stdout, "data = \"unit-a\"")
+}