chore: Addressing lints

Author: yhakbar

internal/cli/commands/catalog/tui/redesign/fault_test.go

@@ -0,0 +1,11 @@
+package redesign_test
+
+import "errors"
+
+// failingWriter always returns an error from Write, for exercising
+// write-failure branches.
+type failingWriter struct{}
+
+func (failingWriter) Write(_ []byte) (int, error) {
+	return 0, errors.New("write failed")
+}

internal/cli/commands/catalog/tui/redesign/model.go

@@ -43,13 +43,6 @@ var (
 	availableButtons = []button{scaffoldBtn, viewSourceBtn}
 )
 
-func (b button) String() string {
-	return []string{
-		"Scaffold",
-		"View Source in Browser",
-	}[b]
-}
-
 type Model struct {
 	lists               [numTabs]list.Model
 	logger              log.Logger
@@ -73,25 +66,6 @@ type Model struct {
 	userNavigated       bool
 }
 
-// ExitMessage returns the styled post-exit message the model set while
-// handling its final action (e.g., a successful copy that generated a
-// terragrunt.values.hcl file). The caller is responsible for printing it
-// after the tea.Program returns, once the alt screen has been torn down.
-func (m Model) ExitMessage() string { //nolint:gocritic
-	return m.exitMessage
-}
-
-// List returns the currently active list — the one filtered by the active
-// tab. Exposed for tests and view code that need to inspect items.
-func (m Model) List() list.Model { //nolint:gocritic
-	return m.lists[m.activeTab]
-}
-
-// ActiveTab returns which of the All/Modules/Templates tabs is focused.
-func (m Model) ActiveTab() tabKind { //nolint:gocritic
-	return m.activeTab
-}
-
 // NewModelStreaming creates a Model with a single initial entry and a channel
 // for receiving additional entries as they are discovered.
 func NewModelStreaming(l log.Logger, opts *options.TerragruntOptions, initial *ComponentEntry, componentCh chan *ComponentEntry) Model {
@@ -103,79 +77,48 @@ func NewModelStreaming(l log.Logger, opts *options.TerragruntOptions, initial *C
 	return m
 }
 
-func newModelWithItems(l log.Logger, opts *options.TerragruntOptions, items []list.Item, componentCh chan *ComponentEntry) Model {
-	listKeys := tui.NewListKeyMap()
-	delegateKeys := tui.NewDelegateKeyMap()
-	pagerKeys := tui.NewPagerKeyMap()
-
-	delegate := newCatalogDelegate(delegateKeys)
-
-	titleStyle := lipgloss.NewStyle().
-		Foreground(lipgloss.Color(titleForegroundColor)).
-		Background(lipgloss.Color(titleBackgroundColor)).
-		Padding(0, 1)
-
-	var lists [numTabs]list.Model
-
-	for i := range int(numTabs) {
-		t := tabKind(i)
+// NewModelWithExitMessageForTest constructs a Model carrying only an exit
+// message, for tests that exercise post-exit message emission without
+// standing up the full catalog list state.
+func NewModelWithExitMessageForTest(msg string) Model {
+	return Model{exitMessage: msg}
+}
 
-		tabItems := filterItemsByTab(items, t)
+// ActiveTab returns which of the All/Modules/Templates tabs is focused.
+func (m Model) ActiveTab() tabKind { //nolint:gocritic
+	return m.activeTab
+}
 
-		lst := list.New(tabItems, delegate, 0, 0)
-		lst.KeyMap = listKeys
-		lst.SetFilteringEnabled(true)
-		// The visible tab strip is rendered in the view; a per-list Title
-		// is redundant, so clear it to keep the tab bar the only label.
-		lst.Title = ""
-		lst.SetShowTitle(false)
-		lst.Styles.Title = titleStyle
-		lists[i] = lst
-	}
+// ExitMessage returns the styled post-exit message the model set while
+// handling its final action (e.g., a successful copy that generated a
+// terragrunt.values.hcl file). The caller is responsible for printing it
+// after the tea.Program returns, once the alt screen has been torn down.
+func (m Model) ExitMessage() string { //nolint:gocritic
+	return m.exitMessage
+}
 
-	vp := viewport.New(viewport.WithWidth(0), viewport.WithHeight(0))
+// Init implements bubbletea.Model.Init
+func (m Model) Init() tea.Cmd { //nolint:gocritic
+	cmds := []tea.Cmd{m.buttonBar.Init()}
 
-	bs := make([]string, len(availableButtons))
-	for i, b := range availableButtons {
-		bs[i] = b.String()
+	if m.componentCh != nil {
+		cmds = append(cmds, m.listenForComponent())
 	}
 
-	bb := buttonbar.New(bs)
-
-	return Model{
-		lists:             lists,
-		listKeys:          listKeys,
-		delegateKeys:      delegateKeys,
-		viewport:          vp,
-		buttonBar:         bb,
-		pagerKeys:         pagerKeys,
-		terragruntOptions: opts,
-		logger:            l,
-		componentCh:       componentCh,
-	}
+	return tea.Batch(cmds...)
 }
 
-// filterItemsByTab returns the subset of items whose Kind belongs in tab t.
-// TabAll returns everything unchanged.
-func filterItemsByTab(items []list.Item, t tabKind) []list.Item {
-	if t == TabAll {
-		return items
-	}
-
-	out := make([]list.Item, 0, len(items))
-
-	for _, it := range items {
-		entry, ok := it.(*ComponentEntry)
-		if !ok {
-			continue
-		}
-
-		if t.matches(entry.Kind()) {
-			out = append(out, entry)
-		}
-	}
+// List returns the currently active list — the one filtered by the active
+// tab. Exposed for tests and view code that need to inspect items.
+func (m Model) List() list.Model { //nolint:gocritic
+	return m.lists[m.activeTab]
+}
 
-	return out
+func (b button) String() string {
+	return []string{
+		"Scaffold",
+		"View Source in Browser",
+	}[b]
 }
 
 // insertComponentSorted inserts a component into every tab whose filter
@@ -246,6 +189,45 @@ func (m *Model) insertIntoList(idx int, entry *ComponentEntry) tea.Cmd {
 	return cmd
 }
 
+func (m Model) listenForComponent() tea.Cmd { //nolint:gocritic
+	ch := m.componentCh
+	if ch == nil {
+		return nil
+	}
+
+	return func() tea.Msg {
+		c, ok := <-ch
+		if !ok {
+			return nil
+		}
+
+		return componentMsg{entry: c}
+	}
+}
+
+// filterItemsByTab returns the subset of items whose Kind belongs in tab t.
+// TabAll returns everything unchanged.
+func filterItemsByTab(items []list.Item, t tabKind) []list.Item {
+	if t == TabAll {
+		return items
+	}
+
+	out := make([]list.Item, 0, len(items))
+
+	for _, it := range items {
+		entry, ok := it.(*ComponentEntry)
+		if !ok {
+			continue
+		}
+
+		if t.matches(entry.Kind()) {
+			out = append(out, entry)
+		}
+	}
+
+	return out
+}
+
 // isDuplicate reports whether any item in the list has the same source path
 // as sourcePath. This uses the stable TerraformSourcePath identity rather
 // than the display title, so distinct components that share a title are not
@@ -262,29 +244,54 @@ func isDuplicate(items []list.Item, sourcePath string) bool {
 	return false
 }
 
-func (m Model) listenForComponent() tea.Cmd { //nolint:gocritic
-	ch := m.componentCh
-	if ch == nil {
-		return nil
-	}
+func newModelWithItems(l log.Logger, opts *options.TerragruntOptions, items []list.Item, componentCh chan *ComponentEntry) Model {
+	listKeys := tui.NewListKeyMap()
+	delegateKeys := tui.NewDelegateKeyMap()
+	pagerKeys := tui.NewPagerKeyMap()
 
-	return func() tea.Msg {
-		c, ok := <-ch
-		if !ok {
-			return nil
-		}
+	delegate := newCatalogDelegate(delegateKeys)
 
-		return componentMsg{entry: c}
+	titleStyle := lipgloss.NewStyle().
+		Foreground(lipgloss.Color(titleForegroundColor)).
+		Background(lipgloss.Color(titleBackgroundColor)).
+		Padding(0, 1)
+
+	var lists [numTabs]list.Model
+
+	for i := range int(numTabs) {
+		t := tabKind(i)
+
+		tabItems := filterItemsByTab(items, t)
+
+		lst := list.New(tabItems, delegate, 0, 0)
+		lst.KeyMap = listKeys
+		lst.SetFilteringEnabled(true)
+		// The visible tab strip is rendered in the view; a per-list Title
+		// is redundant, so clear it to keep the tab bar the only label.
+		lst.Title = ""
+		lst.SetShowTitle(false)
+		lst.Styles.Title = titleStyle
+		lists[i] = lst
 	}
-}
 
-// Init implements bubbletea.Model.Init
-func (m Model) Init() tea.Cmd { //nolint:gocritic
-	cmds := []tea.Cmd{m.buttonBar.Init()}
+	vp := viewport.New(viewport.WithWidth(0), viewport.WithHeight(0))
 
-	if m.componentCh != nil {
-		cmds = append(cmds, m.listenForComponent())
+	bs := make([]string, len(availableButtons))
+	for i, b := range availableButtons {
+		bs[i] = b.String()
 	}
 
-	return tea.Batch(cmds...)
+	bb := buttonbar.New(bs)
+
+	return Model{
+		lists:             lists,
+		listKeys:          listKeys,
+		delegateKeys:      delegateKeys,
+		viewport:          vp,
+		buttonBar:         bb,
+		pagerKeys:         pagerKeys,
+		terragruntOptions: opts,
+		logger:            l,
+		componentCh:       componentCh,
+	}
 }