fix(azure): correct Manged typo in SQL client factory functions (#1809)

* fix(azure): correct Manged typo in SQL client factory functions

Four exported functions misspelled "Managed" as "Manged" in
modules/azure/client_factory.go:

  CreateSQLMangedInstanceClient
  CreateSQLMangedInstanceClientContext
  CreateSQLMangedDatabasesClient
  CreateSQLMangedDatabasesClientContext

Add the correctly-spelled CreateSQLManaged* functions as the canonical
names and convert the typo'd names to // Deprecated: aliases that delegate
to them. Update internal call sites in sql_managedinstance.go to use the
new spellings.

Tagging v1.0 with the typo would lock it into the stable API until a major
version bump; the alias approach keeps backwards compatibility while
steering new code to the correct names.

OSS-3452.

* review: drop redundant 'backwards-compatible alias' docstrings on Manged aliases

The // Deprecated: line already conveys it; matches the cleanup in the
sibling rename PR.

Author: james00012

modules/azure/client_factory.go

@@ -489,9 +489,9 @@ func CreateSQLServerClient(subscriptionID string) (*armsql.ServersClient, error)
 	return CreateSQLServerClientContext(context.Background(), subscriptionID)
 }
 
-// CreateSQLMangedInstanceClientContext is a helper function that will create and setup a sql managed instance client.
+// CreateSQLManagedInstanceClientContext is a helper function that will create and setup a sql managed instance client.
 // The ctx parameter supports cancellation and timeouts.
-func CreateSQLMangedInstanceClientContext(_ context.Context, subscriptionID string) (*armsql.ManagedInstancesClient, error) {
+func CreateSQLManagedInstanceClientContext(_ context.Context, subscriptionID string) (*armsql.ManagedInstancesClient, error) {
 	clientFactory, err := getArmSQLClientFactory(subscriptionID)
 	if err != nil {
 		return nil, err
@@ -500,16 +500,26 @@ func CreateSQLMangedInstanceClientContext(_ context.Context, subscriptionID stri
 	return clientFactory.NewManagedInstancesClient(), nil
 }
 
-// CreateSQLMangedInstanceClient is a helper function that will create and setup a sql managed instance client.
+// CreateSQLManagedInstanceClient is a helper function that will create and setup a sql managed instance client.
 //
-// Deprecated: Use [CreateSQLMangedInstanceClientContext] instead.
-func CreateSQLMangedInstanceClient(subscriptionID string) (*armsql.ManagedInstancesClient, error) {
-	return CreateSQLMangedInstanceClientContext(context.Background(), subscriptionID)
+// Deprecated: Use [CreateSQLManagedInstanceClientContext] instead.
+func CreateSQLManagedInstanceClient(subscriptionID string) (*armsql.ManagedInstancesClient, error) {
+	return CreateSQLManagedInstanceClientContext(context.Background(), subscriptionID)
 }
 
-// CreateSQLMangedDatabasesClientContext is a helper function that will create and setup a sql managed databases client.
+// Deprecated: Use [CreateSQLManagedInstanceClientContext] instead.
+func CreateSQLMangedInstanceClientContext(ctx context.Context, subscriptionID string) (*armsql.ManagedInstancesClient, error) { //nolint:revive,staticcheck // preserving deprecated function name
+	return CreateSQLManagedInstanceClientContext(ctx, subscriptionID)
+}
+
+// Deprecated: Use [CreateSQLManagedInstanceClient] instead.
+func CreateSQLMangedInstanceClient(subscriptionID string) (*armsql.ManagedInstancesClient, error) { //nolint:revive,staticcheck // preserving deprecated function name
+	return CreateSQLManagedInstanceClient(subscriptionID)
+}
+
+// CreateSQLManagedDatabasesClientContext is a helper function that will create and setup a sql managed databases client.
 // The ctx parameter supports cancellation and timeouts.
-func CreateSQLMangedDatabasesClientContext(_ context.Context, subscriptionID string) (*armsql.ManagedDatabasesClient, error) {
+func CreateSQLManagedDatabasesClientContext(_ context.Context, subscriptionID string) (*armsql.ManagedDatabasesClient, error) {
 	clientFactory, err := getArmSQLClientFactory(subscriptionID)
 	if err != nil {
 		return nil, err
@@ -518,11 +528,21 @@ func CreateSQLMangedDatabasesClientContext(_ context.Context, subscriptionID str
 	return clientFactory.NewManagedDatabasesClient(), nil
 }
 
-// CreateSQLMangedDatabasesClient is a helper function that will create and setup a sql managed databases client.
+// CreateSQLManagedDatabasesClient is a helper function that will create and setup a sql managed databases client.
 //
-// Deprecated: Use [CreateSQLMangedDatabasesClientContext] instead.
-func CreateSQLMangedDatabasesClient(subscriptionID string) (*armsql.ManagedDatabasesClient, error) {
-	return CreateSQLMangedDatabasesClientContext(context.Background(), subscriptionID)
+// Deprecated: Use [CreateSQLManagedDatabasesClientContext] instead.
+func CreateSQLManagedDatabasesClient(subscriptionID string) (*armsql.ManagedDatabasesClient, error) {
+	return CreateSQLManagedDatabasesClientContext(context.Background(), subscriptionID)
+}
+
+// Deprecated: Use [CreateSQLManagedDatabasesClientContext] instead.
+func CreateSQLMangedDatabasesClientContext(ctx context.Context, subscriptionID string) (*armsql.ManagedDatabasesClient, error) { //nolint:revive,staticcheck // preserving deprecated function name
+	return CreateSQLManagedDatabasesClientContext(ctx, subscriptionID)
+}
+
+// Deprecated: Use [CreateSQLManagedDatabasesClient] instead.
+func CreateSQLMangedDatabasesClient(subscriptionID string) (*armsql.ManagedDatabasesClient, error) { //nolint:revive,staticcheck // preserving deprecated function name
+	return CreateSQLManagedDatabasesClient(subscriptionID)
 }
 
 // getArmSQLClientFactory gets an arm sql client factory

modules/azure/sql_managedinstance.go

@@ -67,7 +67,7 @@ func GetManagedInstanceContext(t testing.TestingT, ctx context.Context, resGroup
 // GetManagedInstanceContextE retrieves the SQL managed instance object for the given subscription.
 // The ctx parameter supports cancellation and timeouts.
 func GetManagedInstanceContextE(ctx context.Context, subscriptionID string, resGroupName string, managedInstanceName string) (*armsql.ManagedInstance, error) {
-	sqlmiClient, err := CreateSQLMangedInstanceClientContext(ctx, subscriptionID)
+	sqlmiClient, err := CreateSQLManagedInstanceClientContext(ctx, subscriptionID)
 	if err != nil {
 		return nil, err
 	}
@@ -117,7 +117,7 @@ func GetManagedInstanceDatabaseContext(t testing.TestingT, ctx context.Context,
 // GetManagedInstanceDatabaseContextE retrieves the SQL managed database object for the given subscription.
 // The ctx parameter supports cancellation and timeouts.
 func GetManagedInstanceDatabaseContextE(ctx context.Context, subscriptionID string, resGroupName string, managedInstanceName string, databaseName string) (*armsql.ManagedDatabase, error) {
-	sqlmiDBClient, err := CreateSQLMangedDatabasesClientContext(ctx, subscriptionID)
+	sqlmiDBClient, err := CreateSQLManagedDatabasesClientContext(ctx, subscriptionID)
 	if err != nil {
 		return nil, err
 	}