review: trim redundant alias docstrings and update internal AWS callers

- Drop the 'is a backwards-compatible alias for [X]' sentence from each
  // Deprecated: alias declaration. The Deprecated line already conveys it
  and the duplication adds noise across 13 functions.
- Migrate the 22 internal callers in modules/aws/{dynamodb,iam,sqs,
  secretsmanager,rds,ec2,lambda,acm,route53,account,cloudwatch,ebs,sns,
  keypair,ecs,ssm,ec2-syslog,asg,s3,kms,ecr}.go off the deprecated
  *Context aliases and onto the new *ContextE canonical names.

Author: james00012

modules/aws/account.go

@@ -93,7 +93,7 @@ func ExtractAccountIDFromARN(arn string) (string, error) {
 // NewStsClientContextE creates a new STS client.
 // The ctx parameter supports cancellation and timeouts.
 func NewStsClientContextE(t testing.TestingT, ctx context.Context, region string) (*sts.Client, error) {
-	sess, err := NewAuthenticatedSessionContext(ctx, region)
+	sess, err := NewAuthenticatedSessionContextE(ctx, region)
 	if err != nil {
 		return nil, err
 	}

modules/aws/acm.go

@@ -87,7 +87,7 @@ func GetAcmCertificateArnE(t testing.TestingT, awsRegion string, certDomainName
 // NewAcmClientContextE creates a new ACM client.
 // The ctx parameter supports cancellation and timeouts.
 func NewAcmClientContextE(t testing.TestingT, ctx context.Context, region string) (*acm.Client, error) {
-	sess, err := NewAuthenticatedSessionContext(ctx, region)
+	sess, err := NewAuthenticatedSessionContextE(ctx, region)
 	if err != nil {
 		return nil, err
 	}

modules/aws/asg.go

@@ -216,7 +216,7 @@ func WaitForCapacityE(
 // NewAsgClientContextE creates an Auto Scaling Group client.
 // The ctx parameter supports cancellation and timeouts.
 func NewAsgClientContextE(t testing.TestingT, ctx context.Context, region string) (*autoscaling.Client, error) {
-	sess, err := NewAuthenticatedSessionContext(ctx, region)
+	sess, err := NewAuthenticatedSessionContextE(ctx, region)
 	if err != nil {
 		return nil, err
 	}

modules/aws/auth.go

@@ -33,8 +33,6 @@ func NewAuthenticatedSessionContextE(ctx context.Context, region string) (*aws.C
 	return NewAuthenticatedSessionFromDefaultCredentialsContextE(ctx, region)
 }
 
-// NewAuthenticatedSessionContext is a backwards-compatible alias for [NewAuthenticatedSessionContextE].
-//
 // Deprecated: Use [NewAuthenticatedSessionContextE] instead.
 func NewAuthenticatedSessionContext(ctx context.Context, region string) (*aws.Config, error) {
 	return NewAuthenticatedSessionContextE(ctx, region)
@@ -59,8 +57,6 @@ func NewAuthenticatedSessionFromDefaultCredentialsContextE(ctx context.Context,
 	return &cfg, nil
 }
 
-// NewAuthenticatedSessionFromDefaultCredentialsContext is a backwards-compatible alias for [NewAuthenticatedSessionFromDefaultCredentialsContextE].
-//
 // Deprecated: Use [NewAuthenticatedSessionFromDefaultCredentialsContextE] instead.
 func NewAuthenticatedSessionFromDefaultCredentialsContext(ctx context.Context, region string) (*aws.Config, error) {
 	return NewAuthenticatedSessionFromDefaultCredentialsContextE(ctx, region)
@@ -100,8 +96,6 @@ func NewAuthenticatedSessionFromRoleContextE(ctx context.Context, region string,
 	}, nil
 }
 
-// NewAuthenticatedSessionFromRoleContext is a backwards-compatible alias for [NewAuthenticatedSessionFromRoleContextE].
-//
 // Deprecated: Use [NewAuthenticatedSessionFromRoleContextE] instead.
 func NewAuthenticatedSessionFromRoleContext(ctx context.Context, region string, roleARN string) (*aws.Config, error) {
 	return NewAuthenticatedSessionFromRoleContextE(ctx, region, roleARN)
@@ -126,8 +120,6 @@ func CreateAwsSessionWithCredsContextE(_ context.Context, region string, accessK
 	}, nil
 }
 
-// CreateAwsSessionWithCredsContext is a backwards-compatible alias for [CreateAwsSessionWithCredsContextE].
-//
 // Deprecated: Use [CreateAwsSessionWithCredsContextE] instead.
 func CreateAwsSessionWithCredsContext(ctx context.Context, region string, accessKeyID string, secretAccessKey string) (*aws.Config, error) {
 	return CreateAwsSessionWithCredsContextE(ctx, region, accessKeyID, secretAccessKey)
@@ -167,8 +159,6 @@ func CreateAwsSessionWithMfaContextE(ctx context.Context, region string, stsClie
 	}, nil
 }
 
-// CreateAwsSessionWithMfaContext is a backwards-compatible alias for [CreateAwsSessionWithMfaContextE].
-//
 // Deprecated: Use [CreateAwsSessionWithMfaContextE] instead.
 func CreateAwsSessionWithMfaContext(ctx context.Context, region string, stsClient *sts.Client, mfaDevice *types.VirtualMFADevice) (*aws.Config, error) {
 	return CreateAwsSessionWithMfaContextE(ctx, region, stsClient, mfaDevice)
@@ -204,8 +194,6 @@ func ReadPasswordPolicyMinPasswordLengthContextE(ctx context.Context, iamClient
 	return int(*output.PasswordPolicy.MinimumPasswordLength), nil
 }
 
-// ReadPasswordPolicyMinPasswordLengthContext is a backwards-compatible alias for [ReadPasswordPolicyMinPasswordLengthContextE].
-//
 // Deprecated: Use [ReadPasswordPolicyMinPasswordLengthContextE] instead.
 func ReadPasswordPolicyMinPasswordLengthContext(ctx context.Context, iamClient *iam.Client) (int, error) {
 	return ReadPasswordPolicyMinPasswordLengthContextE(ctx, iamClient)

modules/aws/cloudwatch.go

@@ -79,7 +79,7 @@ func GetCloudWatchLogEntriesE(t testing.TestingT, awsRegion string, logStreamNam
 // NewCloudWatchLogsClientContextE creates a new CloudWatch Logs client.
 // The ctx parameter supports cancellation and timeouts.
 func NewCloudWatchLogsClientContextE(t testing.TestingT, ctx context.Context, region string) (*cloudwatchlogs.Client, error) {
-	sess, err := NewAuthenticatedSessionContext(ctx, region)
+	sess, err := NewAuthenticatedSessionContextE(ctx, region)
 	if err != nil {
 		return nil, err
 	}

modules/aws/dynamodb.go

@@ -196,7 +196,7 @@ func GetDynamoDBTableE(t testing.TestingT, region string, tableName string) (*ty
 // NewDynamoDBClientContextE creates a DynamoDB client.
 // The ctx parameter supports cancellation and timeouts.
 func NewDynamoDBClientContextE(t testing.TestingT, ctx context.Context, region string) (*dynamodb.Client, error) {
-	sess, err := NewAuthenticatedSessionContext(ctx, region)
+	sess, err := NewAuthenticatedSessionContextE(ctx, region)
 	if err != nil {
 		return nil, err
 	}

modules/aws/ebs.go

@@ -21,7 +21,7 @@ type EbsAPI interface {
 func DeleteEbsSnapshotContextE(t testing.TestingT, ctx context.Context, region string, snapshot string) error {
 	logger.Default.Logf(t, "Deleting EBS snapshot %s", snapshot)
 
-	sess, err := NewAuthenticatedSessionContext(ctx, region)
+	sess, err := NewAuthenticatedSessionContextE(ctx, region)
 	if err != nil {
 		return err
 	}

modules/aws/ec2-syslog.go

@@ -32,7 +32,7 @@ func GetSyslogForInstanceContextE(t testing.TestingT, ctx context.Context, insta
 
 	logger.Default.Logf(t, "%s", description)
 
-	sess, err := NewAuthenticatedSessionContext(ctx, region)
+	sess, err := NewAuthenticatedSessionContextE(ctx, region)
 	if err != nil {
 		return "", err
 	}

modules/aws/ec2.go

@@ -956,7 +956,7 @@ func getInstanceFieldMapContextE(t testing.TestingT, ctx context.Context, instan
 // NewEc2ClientContextE creates an EC2 client.
 // The ctx parameter supports cancellation and timeouts.
 func NewEc2ClientContextE(t testing.TestingT, ctx context.Context, region string) (*ec2.Client, error) {
-	sess, err := NewAuthenticatedSessionContext(ctx, region)
+	sess, err := NewAuthenticatedSessionContextE(ctx, region)
 	if err != nil {
 		return nil, err
 	}

modules/aws/ecr.go

@@ -172,7 +172,7 @@ func DeleteECRRepoE(t testing.TestingT, region string, repo *types.Repository) e
 // NewECRClientContextE returns a client for the Elastic Container Registry.
 // The ctx parameter supports cancellation and timeouts.
 func NewECRClientContextE(t testing.TestingT, ctx context.Context, region string) (*ecr.Client, error) {
-	sess, err := NewAuthenticatedSessionContext(ctx, region)
+	sess, err := NewAuthenticatedSessionContextE(ctx, region)
 	if err != nil {
 		return nil, err
 	}