fix(azure): correctness fixes across SQL/NoSQL, resource group, container apps, DNS

Parameter-order mismatch silently-swapping args between Context and ContextE twins:
- GetMYSQLServerContext, GetMYSQLDBContext, ListMySQLDBContext
- GetPostgreSQLServerContext, GetPostgreSQLDBContext
- GetSQLServerContext, GetSQLDatabaseContext
- GetSynapseWorkspaceContext, GetSynapseSQLPoolContext
- GetDataFactoryContext
Context wrappers now take (ctx, subscriptionID, resGroupName, ...) matching
their ContextE twins. Deprecated non-context callers updated. Example
tests under test/azure updated.

GetResourceGroupContextE was using case-sensitive string comparison against
the server-side RG name; Azure RG names are case-insensitive. Switched
to strings.EqualFold and added a nil guard.

Container Apps Exists helpers previously returned raw errors on 404
instead of (false, nil):
- ManagedEnvironmentExistsContextE
- ContainerAppExistsContextE
- ContainerAppJobExistsContextE
Now convert ResourceNotFoundErrorExists to (false, nil), matching the
contract used by DataFactoryExistsContextE.

CheckPublicDNSNameAvailabilityContext was silently returning false on
error instead of failing the test. Now uses require.NoError.

Author: james00012

modules/azure/container_apps.go

@@ -40,6 +40,10 @@ func ManagedEnvironmentExistsContextE(ctx context.Context, environmentName strin
 
 	_, err = client.Get(ctx, resourceGroupName, environmentName, nil)
 	if err != nil {
+		if ResourceNotFoundErrorExists(err) {
+			return false, nil
+		}
+
 		return false, err
 	}
 
@@ -136,6 +140,10 @@ func ContainerAppExistsContextE(ctx context.Context, containerAppName string, re
 
 	_, err = client.Get(ctx, resourceGroupName, containerAppName, nil)
 	if err != nil {
+		if ResourceNotFoundErrorExists(err) {
+			return false, nil
+		}
+
 		return false, err
 	}
 
@@ -232,6 +240,10 @@ func ContainerAppJobExistsContextE(ctx context.Context, containerAppName string,
 
 	_, err = client.Get(ctx, resourceGroupName, containerAppName, nil)
 	if err != nil {
+		if ResourceNotFoundErrorExists(err) {
+			return false, nil
+		}
+
 		return false, err
 	}
 

modules/azure/datafactory.go

@@ -55,7 +55,7 @@ func DataFactoryExistsE(dataFactoryName string, resourceGroupName string, subscr
 // GetDataFactoryContext returns the Data Factory object.
 // This function would fail the test if there is an error.
 // The ctx parameter supports cancellation and timeouts.
-func GetDataFactoryContext(t testing.TestingT, ctx context.Context, resGroupName string, factoryName string, subscriptionID string) *armdatafactory.Factory {
+func GetDataFactoryContext(t testing.TestingT, ctx context.Context, subscriptionID string, resGroupName string, factoryName string) *armdatafactory.Factory {
 	t.Helper()
 
 	factory, err := GetDataFactoryContextE(ctx, subscriptionID, resGroupName, factoryName)
@@ -71,7 +71,7 @@ func GetDataFactoryContext(t testing.TestingT, ctx context.Context, resGroupName
 func GetDataFactory(t testing.TestingT, resGroupName string, factoryName string, subscriptionID string) *armdatafactory.Factory {
 	t.Helper()
 
-	return GetDataFactoryContext(t, context.Background(), resGroupName, factoryName, subscriptionID) //nolint:staticcheck
+	return GetDataFactoryContext(t, context.Background(), subscriptionID, resGroupName, factoryName) //nolint:staticcheck
 }
 
 // GetDataFactoryContextE returns the Data Factory object.

modules/azure/mysql.go

@@ -30,7 +30,7 @@ func GetMYSQLServerClientE(subscriptionID string) (*armmysql.ServersClient, erro
 // GetMYSQLServerContext is a helper function that gets the server.
 // This function would fail the test if there is an error.
 // The ctx parameter supports cancellation and timeouts.
-func GetMYSQLServerContext(t testing.TestingT, ctx context.Context, resGroupName string, serverName string, subscriptionID string) *armmysql.Server {
+func GetMYSQLServerContext(t testing.TestingT, ctx context.Context, subscriptionID string, resGroupName string, serverName string) *armmysql.Server {
 	t.Helper()
 
 	mysqlServer, err := GetMYSQLServerContextE(t, ctx, subscriptionID, resGroupName, serverName)
@@ -46,7 +46,7 @@ func GetMYSQLServerContext(t testing.TestingT, ctx context.Context, resGroupName
 func GetMYSQLServer(t testing.TestingT, resGroupName string, serverName string, subscriptionID string) *armmysql.Server {
 	t.Helper()
 
-	return GetMYSQLServerContext(t, context.Background(), resGroupName, serverName, subscriptionID) //nolint:staticcheck
+	return GetMYSQLServerContext(t, context.Background(), subscriptionID, resGroupName, serverName) //nolint:staticcheck
 }
 
 // GetMYSQLServerContextE is a helper function that gets the server.
@@ -99,7 +99,7 @@ func GetMYSQLDBClientE(subscriptionID string) (*armmysql.DatabasesClient, error)
 // GetMYSQLDBContext is a helper function that gets the database.
 // This function would fail the test if there is an error.
 // The ctx parameter supports cancellation and timeouts.
-func GetMYSQLDBContext(t testing.TestingT, ctx context.Context, resGroupName string, serverName string, dbName string, subscriptionID string) *armmysql.Database {
+func GetMYSQLDBContext(t testing.TestingT, ctx context.Context, subscriptionID string, resGroupName string, serverName string, dbName string) *armmysql.Database {
 	t.Helper()
 
 	database, err := GetMYSQLDBContextE(t, ctx, subscriptionID, resGroupName, serverName, dbName)
@@ -115,7 +115,7 @@ func GetMYSQLDBContext(t testing.TestingT, ctx context.Context, resGroupName str
 func GetMYSQLDB(t testing.TestingT, resGroupName string, serverName string, dbName string, subscriptionID string) *armmysql.Database {
 	t.Helper()
 
-	return GetMYSQLDBContext(t, context.Background(), resGroupName, serverName, dbName, subscriptionID) //nolint:staticcheck
+	return GetMYSQLDBContext(t, context.Background(), subscriptionID, resGroupName, serverName, dbName) //nolint:staticcheck
 }
 
 // GetMYSQLDBContextE is a helper function that gets the database.
@@ -150,7 +150,7 @@ func GetMYSQLDBE(t testing.TestingT, subscriptionID string, resGroupName string,
 // ListMySQLDBContext is a helper function that gets all databases per server.
 // This function would fail the test if there is an error.
 // The ctx parameter supports cancellation and timeouts.
-func ListMySQLDBContext(t testing.TestingT, ctx context.Context, resGroupName string, serverName string, subscriptionID string) []*armmysql.Database {
+func ListMySQLDBContext(t testing.TestingT, ctx context.Context, subscriptionID string, resGroupName string, serverName string) []*armmysql.Database {
 	t.Helper()
 
 	dblist, err := ListMySQLDBContextE(t, ctx, subscriptionID, resGroupName, serverName)
@@ -166,7 +166,7 @@ func ListMySQLDBContext(t testing.TestingT, ctx context.Context, resGroupName st
 func ListMySQLDB(t testing.TestingT, resGroupName string, serverName string, subscriptionID string) []*armmysql.Database {
 	t.Helper()
 
-	return ListMySQLDBContext(t, context.Background(), resGroupName, serverName, subscriptionID) //nolint:staticcheck
+	return ListMySQLDBContext(t, context.Background(), subscriptionID, resGroupName, serverName) //nolint:staticcheck
 }
 
 // ListMySQLDBContextE is a helper function that gets all databases per server.

modules/azure/postgresql.go

@@ -30,7 +30,7 @@ func GetPostgreSQLServerClientE(subscriptionID string) (*armpostgresql.ServersCl
 // GetPostgreSQLServerContext is a helper function that gets the server.
 // This function would fail the test if there is an error.
 // The ctx parameter supports cancellation and timeouts.
-func GetPostgreSQLServerContext(t testing.TestingT, ctx context.Context, resGroupName string, serverName string, subscriptionID string) *armpostgresql.Server {
+func GetPostgreSQLServerContext(t testing.TestingT, ctx context.Context, subscriptionID string, resGroupName string, serverName string) *armpostgresql.Server {
 	t.Helper()
 
 	postgresqlServer, err := GetPostgreSQLServerContextE(t, ctx, subscriptionID, resGroupName, serverName)
@@ -46,7 +46,7 @@ func GetPostgreSQLServerContext(t testing.TestingT, ctx context.Context, resGrou
 func GetPostgreSQLServer(t testing.TestingT, resGroupName string, serverName string, subscriptionID string) *armpostgresql.Server {
 	t.Helper()
 
-	return GetPostgreSQLServerContext(t, context.Background(), resGroupName, serverName, subscriptionID) //nolint:staticcheck
+	return GetPostgreSQLServerContext(t, context.Background(), subscriptionID, resGroupName, serverName) //nolint:staticcheck
 }
 
 // GetPostgreSQLServerContextE is a helper function that gets the server.
@@ -99,7 +99,7 @@ func GetPostgreSQLDBClientE(subscriptionID string) (*armpostgresql.DatabasesClie
 // GetPostgreSQLDBContext is a helper function that gets the database.
 // This function would fail the test if there is an error.
 // The ctx parameter supports cancellation and timeouts.
-func GetPostgreSQLDBContext(t testing.TestingT, ctx context.Context, resGroupName string, serverName string, dbName string, subscriptionID string) *armpostgresql.Database {
+func GetPostgreSQLDBContext(t testing.TestingT, ctx context.Context, subscriptionID string, resGroupName string, serverName string, dbName string) *armpostgresql.Database {
 	t.Helper()
 
 	database, err := GetPostgreSQLDBContextE(t, ctx, subscriptionID, resGroupName, serverName, dbName)
@@ -115,7 +115,7 @@ func GetPostgreSQLDBContext(t testing.TestingT, ctx context.Context, resGroupNam
 func GetPostgreSQLDB(t testing.TestingT, resGroupName string, serverName string, dbName string, subscriptionID string) *armpostgresql.Database {
 	t.Helper()
 
-	return GetPostgreSQLDBContext(t, context.Background(), resGroupName, serverName, dbName, subscriptionID) //nolint:staticcheck
+	return GetPostgreSQLDBContext(t, context.Background(), subscriptionID, resGroupName, serverName, dbName) //nolint:staticcheck
 }
 
 // GetPostgreSQLDBContextE is a helper function that gets the database.

modules/azure/publicaddress.go

@@ -118,9 +118,7 @@ func CheckPublicDNSNameAvailabilityContext(t testing.TestingT, ctx context.Conte
 	t.Helper()
 
 	available, err := CheckPublicDNSNameAvailabilityContextE(ctx, location, domainNameLabel, subscriptionID)
-	if err != nil {
-		return false
-	}
+	require.NoError(t, err)
 
 	return available
 }

modules/azure/resourcegroup.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"errors"
 	"fmt"
+	"strings"
 
 	"github.com/Azure/azure-sdk-for-go/sdk/azcore"
 	"github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armresources"
@@ -56,14 +57,19 @@ func ResourceGroupExistsE(resourceGroupName, subscriptionID string) (bool, error
 }
 
 // GetResourceGroupContextE checks whether a resource group name matches the one retrieved from the subscription.
+// Azure resource group names are case-insensitive, so the comparison is performed with EqualFold.
 // The ctx parameter supports cancellation and timeouts.
 func GetResourceGroupContextE(ctx context.Context, resourceGroupName, subscriptionID string) (bool, error) {
 	rg, err := GetAResourceGroupContextE(ctx, resourceGroupName, subscriptionID)
 	if err != nil {
 		return false, err
 	}
 
-	return (resourceGroupName == *rg.Name), nil
+	if rg == nil || rg.Name == nil {
+		return false, nil
+	}
+
+	return strings.EqualFold(resourceGroupName, *rg.Name), nil
 }
 
 // GetResourceGroupE checks whether a resource group name matches the one retrieved from the subscription.

modules/azure/sql.go

@@ -24,7 +24,7 @@ func GetSQLServerClient(subscriptionID string) (*armsql.ServersClient, error) {
 // GetSQLServerContext is a helper function that gets the sql server object.
 // This function would fail the test if there is an error.
 // The ctx parameter supports cancellation and timeouts.
-func GetSQLServerContext(t testing.TestingT, ctx context.Context, resGroupName string, serverName string, subscriptionID string) *armsql.Server {
+func GetSQLServerContext(t testing.TestingT, ctx context.Context, subscriptionID string, resGroupName string, serverName string) *armsql.Server {
 	t.Helper()
 
 	sqlServer, err := GetSQLServerContextE(t, ctx, subscriptionID, resGroupName, serverName)
@@ -40,7 +40,7 @@ func GetSQLServerContext(t testing.TestingT, ctx context.Context, resGroupName s
 func GetSQLServer(t testing.TestingT, resGroupName string, serverName string, subscriptionID string) *armsql.Server {
 	t.Helper()
 
-	return GetSQLServerContext(t, context.Background(), resGroupName, serverName, subscriptionID)
+	return GetSQLServerContext(t, context.Background(), subscriptionID, resGroupName, serverName)
 }
 
 // GetSQLServerContextE is a helper function that gets the sql server object.
@@ -147,7 +147,7 @@ func ListSQLServerDatabasesE(t testing.TestingT, resGroupName string, serverName
 // GetSQLDatabaseContext is a helper function that gets the sql db.
 // This function would fail the test if there is an error.
 // The ctx parameter supports cancellation and timeouts.
-func GetSQLDatabaseContext(t testing.TestingT, ctx context.Context, resGroupName string, serverName string, dbName string, subscriptionID string) *armsql.Database {
+func GetSQLDatabaseContext(t testing.TestingT, ctx context.Context, subscriptionID string, resGroupName string, serverName string, dbName string) *armsql.Database {
 	t.Helper()
 
 	database, err := GetSQLDatabaseContextE(t, ctx, subscriptionID, resGroupName, serverName, dbName)
@@ -163,7 +163,7 @@ func GetSQLDatabaseContext(t testing.TestingT, ctx context.Context, resGroupName
 func GetSQLDatabase(t testing.TestingT, resGroupName string, serverName string, dbName string, subscriptionID string) *armsql.Database {
 	t.Helper()
 
-	return GetSQLDatabaseContext(t, context.Background(), resGroupName, serverName, dbName, subscriptionID)
+	return GetSQLDatabaseContext(t, context.Background(), subscriptionID, resGroupName, serverName, dbName)
 }
 
 // GetSQLDatabaseContextE is a helper function that gets the sql db.

modules/azure/synapse.go

@@ -11,7 +11,7 @@ import (
 // GetSynapseWorkspaceContext retrieves the synapse workspace for the given subscription.
 // This function would fail the test if there is an error.
 // The ctx parameter supports cancellation and timeouts.
-func GetSynapseWorkspaceContext(t testing.TestingT, ctx context.Context, resGroupName string, workspaceName string, subscriptionID string) *armsynapse.Workspace {
+func GetSynapseWorkspaceContext(t testing.TestingT, ctx context.Context, subscriptionID string, resGroupName string, workspaceName string) *armsynapse.Workspace {
 	t.Helper()
 
 	workspace, err := GetSynapseWorkspaceContextE(ctx, subscriptionID, resGroupName, workspaceName)
@@ -48,7 +48,7 @@ func GetSynapseWorkspaceWithClient(ctx context.Context, client *armsynapse.Works
 func GetSynapseWorkspace(t testing.TestingT, resGroupName string, workspaceName string, subscriptionID string) *armsynapse.Workspace {
 	t.Helper()
 
-	return GetSynapseWorkspaceContext(t, context.Background(), resGroupName, workspaceName, subscriptionID)
+	return GetSynapseWorkspaceContext(t, context.Background(), subscriptionID, resGroupName, workspaceName)
 }
 
 // GetSynapseWorkspaceE retrieves the synapse workspace for the given subscription.
@@ -61,7 +61,7 @@ func GetSynapseWorkspaceE(t testing.TestingT, subscriptionID string, resGroupNam
 // GetSynapseSQLPoolContext retrieves the synapse SQL pool for the given subscription.
 // This function would fail the test if there is an error.
 // The ctx parameter supports cancellation and timeouts.
-func GetSynapseSQLPoolContext(t testing.TestingT, ctx context.Context, resGroupName string, workspaceName string, sqlPoolName string, subscriptionID string) *armsynapse.SQLPool {
+func GetSynapseSQLPoolContext(t testing.TestingT, ctx context.Context, subscriptionID string, resGroupName string, workspaceName string, sqlPoolName string) *armsynapse.SQLPool {
 	t.Helper()
 
 	sqlPool, err := GetSynapseSQLPoolContextE(ctx, subscriptionID, resGroupName, workspaceName, sqlPoolName)
@@ -98,7 +98,7 @@ func GetSynapseSQLPoolWithClient(ctx context.Context, client *armsynapse.SQLPool
 func GetSynapseSQLPool(t testing.TestingT, resGroupName string, workspaceName string, sqlPoolName string, subscriptionID string) *armsynapse.SQLPool {
 	t.Helper()
 
-	return GetSynapseSQLPoolContext(t, context.Background(), resGroupName, workspaceName, sqlPoolName, subscriptionID)
+	return GetSynapseSQLPoolContext(t, context.Background(), subscriptionID, resGroupName, workspaceName, sqlPoolName)
 }
 
 // GetSynapseSQLPoolE retrieves the synapse SQL pool for the given subscription.
@@ -115,7 +115,7 @@ func GetSynapseSQLPoolE(subscriptionID string, resGroupName string, workspaceNam
 func GetSynapseSqlPool(t testing.TestingT, resGroupName string, workspaceName string, sqlPoolName string, subscriptionID string) *armsynapse.SQLPool {
 	t.Helper()
 
-	return GetSynapseSQLPoolContext(t, context.Background(), resGroupName, workspaceName, sqlPoolName, subscriptionID)
+	return GetSynapseSQLPoolContext(t, context.Background(), subscriptionID, resGroupName, workspaceName, sqlPoolName)
 }
 
 // GetSynapseSqlPoolE retrieves the synapse SQL pool for the given subscription.

test/azure/terraform_azure_datafactory_example_test.go

@@ -45,7 +45,7 @@ func TestTerraformAzureDataFactoryExample(t *testing.T) {
 	assert.True(t, actualDataFactoryExits)
 
 	// Get data factory details and assert them against the terraform output
-	actualDataFactory := azure.GetDataFactoryContext(t, t.Context(), expectedResourceGroupName, expectedDataFactoryName, "")
+	actualDataFactory := azure.GetDataFactoryContext(t, t.Context(), "", expectedResourceGroupName, expectedDataFactoryName)
 	assert.Equal(t, expectedDataFactoryName, *actualDataFactory.Name)
 	assert.Equal(t, expectedDataFactoryProvisioningState, *actualDataFactory.Properties.ProvisioningState)
 }

test/azure/terraform_azure_mysqldb_example_test.go

@@ -52,15 +52,15 @@ func TestTerraformAzureMySQLDBExample(t *testing.T) {
 	expectedMYSQLDBName := terraform.OutputContext(t, t.Context(), terraformOptions, "mysql_database_name")
 
 	// website::tag::4:: Get mySQL server details and assert them against the terraform output
-	actualMYSQLServer := azure.GetMYSQLServerContext(t, t.Context(), expectedResourceGroupName, expectedMYSQLServerName, "")
+	actualMYSQLServer := azure.GetMYSQLServerContext(t, t.Context(), "", expectedResourceGroupName, expectedMYSQLServerName)
 
 	assert.Equal(t, expectedServerSkuName, *actualMYSQLServer.SKU.Name)
 	assert.Equal(t, expectedServerStoragemMb, strconv.Itoa(int(*actualMYSQLServer.Properties.StorageProfile.StorageMB)))
 
 	assert.Equal(t, armmysql.ServerStateReady, *actualMYSQLServer.Properties.UserVisibleState)
 
 	// website::tag::5:: Get  mySQL server DB details and assert them against the terraform output
-	actualDatabase := azure.GetMYSQLDBContext(t, t.Context(), expectedResourceGroupName, expectedMYSQLServerName, expectedMYSQLDBName, "")
+	actualDatabase := azure.GetMYSQLDBContext(t, t.Context(), "", expectedResourceGroupName, expectedMYSQLServerName, expectedMYSQLDBName)
 
 	assert.Equal(t, expectedDatabaseCharSet, *actualDatabase.Properties.Charset)
 	assert.Equal(t, expectedDatabaseCollation, *actualDatabase.Properties.Collation)