refactor(gcp): rename FetchInstanceWithService → FetchInstanceWithClient for cross-cloud consistency

AWS and Azure modules already use the *WithClient* naming for their
injected-client variants. Keep GCP's public surface consistent even
though the underlying type is called *compute.Service upstream.

Author: james00012

modules/gcp/compute.go

@@ -91,14 +91,14 @@ func FetchInstanceContextE(t testing.TestingT, ctx context.Context, projectID st
 		return nil, err
 	}
 
-	return FetchInstanceWithServiceContextE(t, ctx, service, projectID, name)
+	return FetchInstanceWithClientContextE(t, ctx, service, projectID, name)
 }
 
-// FetchInstanceWithServiceContextE queries GCP to return an instance of the Compute Instance type
+// FetchInstanceWithClientContextE queries GCP to return an instance of the Compute Instance type
 // using the supplied *compute.Service. Prefer this variant in unit tests where the service is
 // backed by an httptest fake server (see compute_unit_test.go for the pattern).
 // The ctx parameter supports cancellation and timeouts.
-func FetchInstanceWithServiceContextE(t testing.TestingT, ctx context.Context, service *compute.Service, projectID string, name string) (*Instance, error) {
+func FetchInstanceWithClientContextE(t testing.TestingT, ctx context.Context, service *compute.Service, projectID string, name string) (*Instance, error) {
 	logger.Default.Logf(t, "Getting Compute Instance %s", name)
 
 	// If we want to fetch an Instance without knowing its Zone, we have to query GCP for all Instances in the project

modules/gcp/compute_unit_test.go

@@ -107,7 +107,7 @@ func TestGetPublicIPContextE(t *testing.T) {
 	}
 }
 
-func TestFetchInstanceWithServiceContextE(t *testing.T) {
+func TestFetchInstanceWithClientContextE(t *testing.T) {
 	t.Parallel()
 
 	const projectID = "my-project"
@@ -141,7 +141,7 @@ func TestFetchInstanceWithServiceContextE(t *testing.T) {
 
 			svc := newFakeComputeService(t, handler)
 
-			instance, err := gcp.FetchInstanceWithServiceContextE(t, context.Background(), svc, projectID, tc.target)
+			instance, err := gcp.FetchInstanceWithClientContextE(t, context.Background(), svc, projectID, tc.target)
 			if tc.wantErrMsg != "" {
 				require.Error(t, err)
 				assert.Contains(t, err.Error(), tc.wantErrMsg)