chore: Linting the random package

Author: yhakbar

modules/random/random.go

@@ -27,10 +27,10 @@ func RandomString(elements []string) string {
 const base62chars = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz"
 const uniqueIDLength = 6 // Should be good for 62^6 = 56+ billion combinations
 
-// UniqueId returns a unique (ish) id we can attach to resources and tfstate files so they don't conflict with each other
+// UniqueID returns a unique (ish) id we can attach to resources and tfstate files so they don't conflict with each other
 // Uses base 62 to generate a 6 character string that's unlikely to collide with the handful of tests we run in
 // parallel. Based on code here: http://stackoverflow.com/a/9543797/483528
-func UniqueId() string {
+func UniqueID() string {
 	var out bytes.Buffer
 
 	generator := newRand()
@@ -41,6 +41,15 @@ func UniqueId() string {
 	return out.String()
 }
 
+// UniqueId is deprecated, use UniqueID instead.
+//
+// Deprecated: Use UniqueID.
+//
+//nolint:staticcheck,revive
+func UniqueId() string {
+	return UniqueID()
+}
+
 // newRand creates a new random number generator, seeding it with the current system time.
 func newRand() *rand.Rand {
 	return rand.New(rand.NewSource(time.Now().UnixNano()))

modules/random/random_test.go

@@ -1,9 +1,10 @@
-package random
+package random_test
 
 import (
 	"strconv"
 	"testing"
 
+	"github.com/gruntwork-io/terratest/modules/random"
 	"github.com/stretchr/testify/assert"
 )
 
@@ -14,7 +15,7 @@ func TestRandom(t *testing.T) {
 	max := 100
 
 	for i := 0; i < 100000; i++ {
-		value := Random(min, max)
+		value := random.Random(min, max)
 		assert.True(t, value >= min && value <= max)
 	}
 }
@@ -31,7 +32,7 @@ func TestRandomInt(t *testing.T) {
 	}
 
 	for i := 0; i < 100000; i++ {
-		value := RandomInt(list)
+		value := random.RandomInt(list)
 		assert.Contains(t, list, value)
 	}
 }
@@ -48,18 +49,18 @@ func TestRandomString(t *testing.T) {
 	}
 
 	for i := 0; i < 100000; i++ {
-		value := RandomString(list)
+		value := random.RandomString(list)
 		assert.Contains(t, list, value)
 	}
 }
 
-func TestUniqueId(t *testing.T) {
+func TestUniqueID(t *testing.T) {
 	t.Parallel()
 
 	previouslySeen := map[string]bool{}
 
 	for i := 0; i < 100; i++ {
-		uniqueID := UniqueId()
+		uniqueID := random.UniqueID()
 		assert.Len(t, uniqueID, 6)
 		assert.NotContains(t, previouslySeen, uniqueID)