fix(aws): paginate IAM, RDS, and ECR list calls (#1812)

Four AWS list calls made a single API request without iterating pagination
tokens, silently capping results at the first page. Same class of bug as
the EC2 DescribeInstances/DescribeTags fixes already in v1.

- iam.ListPolicyVersions in GetIamPolicyDocumentContextE searched for the
  default version, which could live on any page once AWS lifts the current
  five-version limit.
- rds.DescribeOptionGroups in GetOptionsOfOptionGroupContextE filtered by
  name; switching to NewDescribeOptionGroupsPaginator keeps the contract
  defensive against any future pagination changes.
- rds.DescribeOrderableDBInstanceOptions in instanceTypeExistsForEngineAndRegionContextE
  could miss matches if the first page was empty but later pages had results.
- ecr.ListImages in DeleteECRRepoContextE deleted only the first page of
  images, leaking the rest and leaving DeleteRepository to fail.

Switch each to the SDK's paginator helpers and the established loop pattern
(see modules/aws/ec2.go:338).

OSS-3454.

Author: james00012

modules/aws/ecr.go

@@ -119,23 +119,26 @@ func DeleteECRRepoContextE(t testing.TestingT, ctx context.Context, region strin
 		return err
 	}
 
-	resp, err := client.ListImages(ctx, &ecr.ListImagesInput{RepositoryName: repo.RepositoryName})
-	if err != nil {
-		return err
-	}
+	paginator := ecr.NewListImagesPaginator(client, &ecr.ListImagesInput{RepositoryName: repo.RepositoryName})
+	for paginator.HasMorePages() {
+		page, err := paginator.NextPage(ctx)
+		if err != nil {
+			return err
+		}
+
+		if len(page.ImageIds) == 0 {
+			continue
+		}
 
-	if len(resp.ImageIds) > 0 {
-		_, err = client.BatchDeleteImage(ctx, &ecr.BatchDeleteImageInput{
+		if _, err := client.BatchDeleteImage(ctx, &ecr.BatchDeleteImageInput{
 			RepositoryName: repo.RepositoryName,
-			ImageIds:       resp.ImageIds,
-		})
-		if err != nil {
+			ImageIds:       page.ImageIds,
+		}); err != nil {
 			return err
 		}
 	}
 
-	_, err = client.DeleteRepository(ctx, &ecr.DeleteRepositoryInput{RepositoryName: repo.RepositoryName})
-	if err != nil {
+	if _, err := client.DeleteRepository(ctx, &ecr.DeleteRepositoryInput{RepositoryName: repo.RepositoryName}); err != nil {
 		return err
 	}
 

modules/aws/iam.go

@@ -110,18 +110,21 @@ func GetIamPolicyDocumentContextE(t testing.TestingT, ctx context.Context, regio
 		return "", err
 	}
 
-	versions, err := iamClient.ListPolicyVersions(ctx, &iam.ListPolicyVersionsInput{
+	var defaultVersion string
+
+	paginator := iam.NewListPolicyVersionsPaginator(iamClient, &iam.ListPolicyVersionsInput{
 		PolicyArn: &policyARN,
 	})
-	if err != nil {
-		return "", err
-	}
-
-	var defaultVersion string
+	for paginator.HasMorePages() {
+		page, err := paginator.NextPage(ctx)
+		if err != nil {
+			return "", err
+		}
 
-	for _, version := range versions.Versions {
-		if version.IsDefaultVersion && version.VersionId != nil {
-			defaultVersion = *version.VersionId
+		for _, version := range page.Versions {
+			if version.IsDefaultVersion && version.VersionId != nil {
+				defaultVersion = *version.VersionId
+			}
 		}
 	}
 

modules/aws/rds.go

@@ -369,18 +369,21 @@ func GetOptionsOfOptionGroupContextE(t testing.TestingT, ctx context.Context, op
 		return []types.Option{}, err
 	}
 
-	input := rds.DescribeOptionGroupsInput{OptionGroupName: aws.String(optionGroupName)}
-
-	output, err := rdsClient.DescribeOptionGroups(ctx, &input)
-	if err != nil {
-		return []types.Option{}, err
-	}
+	paginator := rds.NewDescribeOptionGroupsPaginator(rdsClient, &rds.DescribeOptionGroupsInput{
+		OptionGroupName: aws.String(optionGroupName),
+	})
+	for paginator.HasMorePages() {
+		page, err := paginator.NextPage(ctx)
+		if err != nil {
+			return []types.Option{}, err
+		}
 
-	if len(output.OptionGroupsList) == 0 {
-		return []types.Option{}, fmt.Errorf("no option groups found for name %s in region %s", optionGroupName, awsRegion)
+		if len(page.OptionGroupsList) > 0 {
+			return page.OptionGroupsList[0].Options, nil
+		}
 	}
 
-	return output.OptionGroupsList[0].Options, nil
+	return []types.Option{}, fmt.Errorf("no option groups found for name %s in region %s", optionGroupName, awsRegion)
 }
 
 // GetOptionsOfOptionGroupContext gets the options of the option group specified.
@@ -624,19 +627,20 @@ func GetRecommendedRdsInstanceTypeWithClientE(t testing.TestingT, rdsClient *rds
 // instanceTypeExistsForEngineAndRegionContextE returns a boolean that represents whether the provided instance type (e.g. db.t2.micro) exists for the given region and db engine type.
 // This function will return an error if the RDS AWS SDK call fails.
 func instanceTypeExistsForEngineAndRegionContextE(ctx context.Context, client *rds.Client, engine string, engineVersion string, instanceType string) (bool, error) {
-	input := rds.DescribeOrderableDBInstanceOptionsInput{
+	paginator := rds.NewDescribeOrderableDBInstanceOptionsPaginator(client, &rds.DescribeOrderableDBInstanceOptionsInput{
 		Engine:          aws.String(engine),
 		EngineVersion:   aws.String(engineVersion),
 		DBInstanceClass: aws.String(instanceType),
-	}
-
-	out, err := client.DescribeOrderableDBInstanceOptions(ctx, &input)
-	if err != nil {
-		return false, err
-	}
+	})
+	for paginator.HasMorePages() {
+		page, err := paginator.NextPage(ctx)
+		if err != nil {
+			return false, err
+		}
 
-	if len(out.OrderableDBInstanceOptions) > 0 {
-		return true, nil
+		if len(page.OrderableDBInstanceOptions) > 0 {
+			return true, nil
+		}
 	}
 
 	return false, nil