Creating new line in large files (>100 KB, 5000 lines) becomes increasingly slow.

[Mapalmeira]

⚠️ This issue respects the following points: ⚠️

• This is a bug. Not a question or feature request.
• The topic is not already reported at Issues. (I've searched it).
• Markor is up to date. See Releases for the latest version. Updates are available from F-Droid and GitHub.
• The bug is still present in the latest development version (git master). (Please download and try the test version of Markor, named Marder. Don't worry; Markor and Marder appear as completely separate applications. You can install both side-by-side, and Markor settings are not touched. In case the issue is resolved there, you don't need to create a bug report. The change will be part of the next Markor update.)

Description

When dealing with large text files, with more than 100 KB and 5000 lines, a noticeable delay occurs when creating new lines. Other characters do not have delay,

Steps to reproduce

1. Create an artifically large .md file with many lines by copying something over and over again. The bigger, the more noticeable the delay will be.
2. Open this .md file with markor
3. Try to add a new line and notice a delay.

Information

Android version: 16
Device: Samsung Galaxy
App Version: 2.15.2

Source

F-Droid

Format / File type

Markdown

Additional info / Log

-

[harshad1]

Expected. Especially with highlighting enabled

If you can find me an open source text editor which handles these files well I can try to extract lessons

[Mapalmeira]

Hello, thanks for assessing this issue.

I get what you're saying. Indeed every text editor becomes laggy at some point, but I don't think it's one of those cases. 100 KB files are large, but still not THAT much.

I tried editing the same file with another open-source Android editor, https://github.com/maxistar/TextPad, and it didn't lag. Also, the slowdown happens only when inserting new lines; typing characters on an existing line is fine. That points to this issue being something else.

I also tried disabling highlighting, and it didn’t make any difference.

[harshad1]

Turn of autoformat and check?

[Mapalmeira]

Turned off everything. Still lags on new lines.

[guanglinn]

I have seen many issues related large text files on Markor. Maybe we can implement the feature to load and edit large text files.

Here are some ideas about this:
How to implement the feature to load and edit large text files?

How to use Java to implement the feature to load and edit large text files?

How to use Android EditText to implement the feature to load and edit large text files?

[gsantner]

Majority of ""Markor specific logic"" uses standard Android TextView/EditText as base. Swapping that out basically means creating somewhat a new app.
And unfortunate, TextView/EditText happens to be not the most performant core solution for what we do with it. But we happen to center around it.

As such issues are open frequently, I will just close them in future as ""it is slow for me"" doesn't much help in terms of feedback, more or less duplicates.
We know it's slow on certain devices or certain scenarios..but Markor tries to find a good working solution for it so majority can use it fine for what they want to do with it.
I use Markor on a ancient device which already struggles with one browser tab / web browsing, but Markor works fine there for the files I have..so generally shouldn't be as bad as it sounds.

[hueldoeu]

Expected. Especially with highlighting enabled

If you can find me an open source text editor which handles these files well I can try to extract lessons

Editor by Bill Farmer https://f-droid.org/packages/org.billthefarmer.editor/

I'm honest when this bug didn't occur in versions of markor Before 2023 #2662

[guanglinn]

#2716 - Performance degradation from 2.14.1 to 2.15.2

#2652 - v2.15: App crashes and very slow while you edit a file

[Mapalmeira]

Can confirm this bug doesn't occur at 2.14.1!

[hueldoeu]

Can confirm this bug doesn't occur at 2.14.1!

can somebody spot the differences in souce code please. i have to slaughter a corona bitch who thinks it is funny to disturb me

i will unsub from this.

[guanglinn]

This line of code is very slow (over 10 seconds) when I open a 500 KB text file.

net/gsantner/markor/activity/DocumentEditAndViewFragment.java#L407

But this code is just setting the read text to EditText, might not have much reference value to solve this issue.

[hueldoeu]

This line of code is very slow (over 10 seconds) when I open a 500 KB text file.

net/gsantner/markor/activity/DocumentEditAndViewFragment.java#L407

But this code is just setting the read text to EditText, might not have much reference value to solve this issue.

how did you find out? what's the name of this magic mystery