We have put package.json and pnpm-lock.yaml in the untraced option for chromatic
This means chromatic ignores these files when working out which stories have been affected and need to be re-snapshotted.
The implication of this is that if dependencies update that may affect our UI like react, or our component libraries, they would be ignored by turbosnap and will use the previous cached snapshots, you can see this happening by looking at the chromatic results of dependabot PRs, they all have 100% turbosnaps.
This firstly could cause a dependabot update of a library to break the UI without us knowing.
And secondly can cause updates in other PRs not to show until the snapshot is fully run on another PR, which happened when support-dotcom-components was updated in #16367, this silently broke one of the stories. Which came up in a later PR that caused the shapshot to re-run #16356 (https://www.chromatic.com/build?appId=63e251470cfbe61776b0ef19&number=16649)
We have put
package.jsonandpnpm-lock.yamlin theuntracedoption for chromaticThis means chromatic ignores these files when working out which stories have been affected and need to be re-snapshotted.
The implication of this is that if dependencies update that may affect our UI like react, or our component libraries, they would be ignored by turbosnap and will use the previous cached snapshots, you can see this happening by looking at the chromatic results of dependabot PRs, they all have 100% turbosnaps.
This firstly could cause a dependabot update of a library to break the UI without us knowing.
And secondly can cause updates in other PRs not to show until the snapshot is fully run on another PR, which happened when
support-dotcom-componentswas updated in #16367, this silently broke one of the stories. Which came up in a later PR that caused the shapshot to re-run #16356 (https://www.chromatic.com/build?appId=63e251470cfbe61776b0ef19&number=16649)