Skip to content

Commit 0497ec1

Browse files
committed
Update etag-caching
1 parent 220ab4b commit 0497ec1

5 files changed

Lines changed: 8 additions & 10 deletions

File tree

build.sbt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ name := "facia-api-client"
66

77
description := "Scala client for The Guardian's Facia JSON API"
88

9-
ThisBuild / scalaVersion := "2.13.15"
9+
ThisBuild / scalaVersion := "2.13.16"
1010

1111
val sonatypeReleaseSettings = Seq(
1212
releaseVersion := fromAggregatedAssessedCompatibilityWithLatestRelease().value,
@@ -26,8 +26,7 @@ val sonatypeReleaseSettings = Seq(
2626
def artifactProducingSettings(supportScala3: Boolean) = Seq(
2727
organization := "com.gu",
2828
licenses := Seq(License.Apache2),
29-
resolvers ++= Resolver.sonatypeOssRepos("releases"),
30-
crossScalaVersions := Seq(scalaVersion.value) ++ (if (supportScala3) Seq("3.3.3") else Seq.empty),
29+
crossScalaVersions := Seq(scalaVersion.value) ++ (if (supportScala3) Seq("3.3.6") else Seq.empty),
3130
scalacOptions := Seq(
3231
"-release:8",
3332
"-feature",

facia-json/src/main/scala/com/gu/facia/client/ApiClient.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ package com.gu.facia.client
22

33
import com.gu.etagcaching.FreshnessPolicy.AlwaysWaitForRefreshedValue
44
import com.gu.etagcaching.aws.s3.{ObjectId, S3ByteArrayFetching}
5-
import com.gu.etagcaching.fetching.Fetching
65
import com.gu.etagcaching.{ConfigCache, ETagCache}
76
import com.gu.facia.client.models.{CollectionJson, ConfigJson}
87
import play.api.libs.json.{Format, Json}

facia-json/src/test/scala/com/gu/facia/client/ApiClientSpec.scala

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,18 +18,18 @@ import scala.util.hashing.MurmurHash3
1818
object FakeS3Fetching extends S3ByteArrayFetching with ResourcesHelper {
1919
private def pretendETagFor(bytes: Array[Byte]): String = MurmurHash3.bytesHash(bytes).toHexString
2020

21-
override def fetch(objectId: ObjectId)(implicit ec: ExecutionContext): Future[MissingOrETagged[Array[Byte]]] = Future {
21+
override def fetch(objectId: ObjectId): Future[MissingOrETagged[Array[Byte]]] = Future.successful {
2222
slurpBytes(objectId.key).fold(Missing: MissingOrETagged[Array[Byte]]) { bytes =>
2323
ETaggedData(pretendETagFor(bytes), bytes)
2424
}
2525
}
2626

27-
override def fetchOnlyIfETagChanged(objectId: ObjectId, oldETag: String)(implicit ec: ExecutionContext): Future[Option[MissingOrETagged[Array[Byte]]]] = {
27+
override def fetchOnlyIfETagChanged(objectId: ObjectId, oldETag: String): Future[Option[MissingOrETagged[Array[Byte]]]] = {
2828
fetch(objectId).map {
29-
case taggedData: ETaggedData[_] =>
29+
case taggedData: ETaggedData[Array[Byte]] =>
3030
Option.unless(oldETag == taggedData.eTag)(taggedData) // simulate a Not-Modified response, if there's no change in ETag
3131
case x => Some(x)
32-
}
32+
}(ExecutionContext.parasitic)
3333
}
3434
}
3535

project/build.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
sbt.version=1.10.1
1+
sbt.version=1.11.5

project/dependencies.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import sbt._
22

33
object Dependencies {
44
val capiVersion = "35.0.0"
5-
val eTagCachingVersion = "7.0.0"
5+
val eTagCachingVersion = "11.0.0-PREVIEW.rearrange-executioncontexts.2025-09-04T1417.81632f48"
66

77
val awsS3SdkV1 = "com.amazonaws" % "aws-java-sdk-s3" % "1.12.765"
88
val eTagCachingS3Base = "com.gu.etag-caching" %% "aws-s3-base" % eTagCachingVersion

0 commit comments

Comments
 (0)