Apps that depend on `facia-json` shouldn't be forced to include AWS SDK v1

[rtyley]

AWS SDK for Java v1 will soon be EOL, and as teams update their codebases to use AWS SDK v2, it'll become troublesome that facia-json pulls in AWS SDK v1, even if you're using it with AWS SDK v2:

facia-scala-client/build.sbt

Line 68 in 220ab4b

awsS3SdkV1, // ideally, this would be pushed out to a separate FAPI artifact, or just not used directly at all

So long as all consumers of fapi-client/facia-json are updated to use the new constructor of com.gu.facia.client.ApiClient (ie ApiClient.withCaching()) we can get rid of the legacy ApiClient() constructor that requires a dependency on AWS SDK v1:

facia-scala-client/facia-json/src/main/scala/com/gu/facia/client/ApiClient.scala

Lines 21 to 28 in 220ab4b

	/**
	* Legacy constructor for creating a client that does not support caching. Use `ApiClient.withCaching()` instead.
	*/
	def apply(
	bucket: String,
	environment: String, // e.g., CODE, PROD, DEV ...
	s3Client: S3Client
	)(implicit executionContext: ExecutionContext): ApiClient = new ApiClient {

Usages of com.gu.facia.client.ApiClient()

• apple-news https://github.com/guardian/apple-news/pull/398
• frontend Enable ETag-caching & AWS SDK v2 on Facia API requests frontend#27715
• ophan https://github.com/guardian/ophan/pull/6741
• facia-tool
• story-packages
• mobile-fastly-cache-purger - concerningly, this is currently limited to v7.0.0 of this library at the moment: https://github.com/guardian/mobile-fastly-cache-purger/pull/63
• mobile-apps-api - there's a wrinkle here, because this project has its own CachedApiClient that's probably unnecessary now that etag-caching is provided with ApiClient.withCaching() - ultimately, the upgrade should allow us to delete CachedApiClient.

See also

• Add ETag-caching and AWS SDK v2 support #287