delete account changes (WIP)

Author: pvighi

src/client/pages/DeleteAccount.tsx

@@ -1,10 +1,8 @@
-import React, { useState } from 'react';
 import { RadioGroup, Radio } from '@guardian/source/react-components';
 import { MainForm } from '@/client/components/MainForm';
 import { MainBodyText } from '@/client/components/MainBodyText';
 import { ExternalLink } from '@/client/components/ExternalLink';
 import locations from '@/shared/lib/locations';
-import { PasswordInput } from '@/client/components/PasswordInput';
 import { Divider } from '@guardian/source-development-kitchen/react-components';
 import { DeleteAccountReturnLink } from '@/client/components/DeleteAccountReturnLink';
 import { buildUrlWithQueryParams } from '@/shared/lib/routeUtils';
@@ -37,15 +35,10 @@ const radioGroupStyles = css`
 
 export const DeleteAccount = ({
 	queryParams,
-	fieldErrors = [],
 	formError,
 	error,
 	shortRequestId,
 }: Props) => {
-	const [passwordError] = useState<string | undefined>(
-		fieldErrors.find((fieldError) => fieldError.field === 'password')?.message,
-	);
-
 	return (
 		<MinimalLayout
 			shortRequestId={shortRequestId}
@@ -228,16 +221,6 @@ export const DeleteAccount = ({
 				<MainBodyText>
 					<strong>Confirm account deletion</strong>
 				</MainBodyText>
-				<MainBodyText>
-					Please re-enter password to confirm the you have understood the
-					conditions and would like to proceed with account deletion.
-				</MainBodyText>
-				{/* password input */}
-				<PasswordInput
-					error={passwordError}
-					label="Password"
-					autoComplete="current-password"
-				/>
 			</MainForm>
 			<DeleteAccountReturnLink />
 		</MinimalLayout>

src/server/routes/delete.ts

@@ -9,7 +9,6 @@ import { ApiError } from '@/server/models/Error';
 import { logger } from '@/server/lib/serverSideLogger';
 import { mergeRequestState } from '@/server/lib/requestState';
 import { getUser } from '@/server/lib/okta/api/users';
-import { authenticate } from '@/server/lib/okta/api/authentication';
 import { OktaError } from '@/server/models/okta/Error';
 import {
 	performAuthorizationCodeFlow,
@@ -87,31 +86,6 @@ router.get(
 				return res.type('html').send(html);
 			}
 
-			// check if the user has a password set
-			if (
-				!user.credentials.password ||
-				/**
-				 * Playwright Test
-				 *
-				 * This code checks if we're running in Playwright to
-				 * mock the user's password
-				 */
-				(runningInPlaywright && playwrightMockStateCookie === 'noPassword')
-			) {
-				// if not, ask them to set a password
-				const html = renderer('/delete-set-password', {
-					pageTitle: 'Create Password',
-					requestState: mergeRequestState(state, {
-						queryParams: {
-							...state.queryParams,
-							// force the returnUrl to be the delete page after setting a password
-							returnUrl: joinUrl(profileUrl, req.path),
-						},
-					}),
-				});
-				return res.type('html').send(html);
-			}
-
 			// get the user's attributes from the members data api
 			const userAttributes = await getUserAttributes({
 				accessToken: state.oauthState.accessToken.toString(),
@@ -251,31 +225,7 @@ router.post(
 			);
 		}
 
-		const { password = '' } = req.body;
-
 		try {
-			const { email } = state.oauthState.idToken.claims;
-
-			// attempt to authenticate with okta
-			// if authentication fails, it will fall through to the catch
-			const response = await authenticate(
-				{
-					username: email as string,
-					password,
-				},
-				req.ip,
-			);
-
-			// we only support the SUCCESS status for Okta authentication in gateway
-			// Other statuses could be supported in the future https://developer.okta.com/docs/reference/api/authn/#transaction-state
-			if (response.status !== 'SUCCESS') {
-				throw new ApiError({
-					message:
-						'User authenticating was blocked due to unsupported Okta Authentication status property',
-					status: 403,
-				});
-			}
-
 			// perform the authorization code flow to get an access token specifically for deleting the user
 			return performAuthorizationCodeFlow(req, res, {
 				redirectUri: ProfileOpenIdClientRedirectUris.DELETE,
@@ -294,7 +244,7 @@ router.post(
 							fieldErrors: [
 								{
 									field: 'password',
-									message: 'Password is incorrect',
+									message: 'Password is incorrect', //todo
 								},
 							],
 						},