Skip to content

Commit 06cabac

Browse files
committed
remove commentary field
1 parent 411457c commit 06cabac

6 files changed

Lines changed: 1 addition & 9 deletions

File tree

api-models/src/main/scala/com/gu/mobile.notifications.client/models/Payloads.scala

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,6 @@ object FootballMatchStatusPayload {
192192
"matchStatus" -> o.matchStatus,
193193
"eventId" -> o.eventId,
194194
"kickOffTimestamp" -> o.kickOffTimestamp,
195-
"matchCommentary" -> o.matchCommentary,
196195
"debug" -> o.debug
197196
)
198197
}
@@ -224,7 +223,6 @@ case class FootballMatchStatusPayload(
224223
matchStatus: String,
225224
eventId: String,
226225
kickOffTimestamp: Option[Long] = None,
227-
matchCommentary: Option[String] = None,
228226
debug: Boolean,
229227
dryRun: Option[Boolean]
230228
) extends NotificationPayload with derivedId {

common/src/main/scala/models/Notification.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,6 @@ case class FootballMatchStatusNotification(
160160
matchStatus: String,
161161
eventId: String,
162162
kickOffTimestamp: Option[Long] = None,
163-
matchCommentary: Option[String] = None,
164163
debug: Boolean,
165164
dryRun: Option[Boolean]
166165
) extends Notification

football/src/main/scala/com/gu/mobile/notifications/football/notificationbuilders/MatchStatusNotificationBuilder.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@ class MatchStatusNotificationBuilder(mapiHost: String) {
6868
topic = topics,
6969
matchStatus = status,
7070
eventId = UUID.nameUUIDFromBytes(triggeringEvent.eventId.getBytes).toString,
71-
matchCommentary = matchInfo.comments,
7271
kickOffTimestamp = Some(matchInfo.date.toEpochSecond),
7372
debug = false,
7473
dryRun = None

notificationworkerlambda/src/main/scala/com/gu/notifications/worker/delivery/fcm/models/payload/FcmPayloadBuilder.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,6 @@ object FcmPayloadBuilder {
127127
++ matchStatusAlert.roundName.map(Keys.RoundName -> _).toMap
128128
++ Some(Keys.HomeTeamRedCards -> matchStatusAlert.homeTeamRedCards.toString).toMap
129129
++ Some(Keys.AwayTeamRedCards -> matchStatusAlert.awayTeamRedCards.toString).toMap
130-
++ matchStatusAlert.matchCommentary.map(Keys.MatchCommentary -> _).toMap
131130
++ matchStatusAlert.kickOffTimestamp.map(Keys.KickOffTimestamp -> _.toString).toMap
132131
++ matchStatusAlert.homeTeamPenalties.map(p => Map(
133132
Keys.HomeTeamPenaltiesScored -> p.scored.toString,

notificationworkerlambda/src/main/scala/com/gu/notifications/worker/delivery/fcm/models/payload/Keys.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ object Keys {
4646
final val AwayTeamPenaltiesMissed = "awayTeamPenaltiesMissed"
4747
final val AwayTeamPenaltiesSaved = "awayTeamPenaltiesSaved"
4848
final val RoundName = "roundName"
49-
final val MatchCommentary = "matchCommentary"
5049
final val KickOffTimestamp = "kickOffTimestamp"
5150

5251
final val EditionsDate = "date"

notificationworkerlambda/src/test/scala/com/gu/notifications/worker/delivery/fcm/models/payload/FcmPayloadBuilderSpec.scala

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ class FcmPayloadBuilderSpec extends Specification with Matchers {
2828
"generate correct data for Match Status notification" in new MatchStatusNotificationScope {
2929
check()
3030
}
31-
"include matchCommentary, kickOffTimestamp and penalty shootout scores in Match Status notification when present" in new MatchStatusNotificationWithOptionalFieldsScope {
31+
"include kickOffTimestamp and penalty shootout scores in Match Status notification when present" in new MatchStatusNotificationWithOptionalFieldsScope {
3232
check()
3333
}
3434
"generate correct data for Editions notification" in new EditionsScope {
@@ -299,7 +299,6 @@ class FcmPayloadBuilderSpec extends Specification with Matchers {
299299
eventId = "2",
300300
debug = true,
301301
dryRun = None,
302-
matchCommentary = Some("Argentina win 4-3 on penalties."),
303302
kickOffTimestamp = Some(1746619200L),
304303
homeTeamPenalties = Some(models.PenaltyScore(scored = 3, missed = 1, saved = 0)),
305304
awayTeamPenalties = Some(models.PenaltyScore(scored = 2, missed = 0, saved = 1))
@@ -326,7 +325,6 @@ class FcmPayloadBuilderSpec extends Specification with Matchers {
326325
"venue" -> "Venue",
327326
"homeTeamRedCards" -> "0",
328327
"awayTeamRedCards" -> "0",
329-
Keys.MatchCommentary -> "Argentina win 4-3 on penalties.",
330328
Keys.KickOffTimestamp -> "1746619200",
331329
Keys.HomeTeamPenaltiesScored -> "3",
332330
Keys.HomeTeamPenaltiesMissed -> "1",

0 commit comments

Comments
 (0)