Switch to using GuCDK-defined load balancer

Updates the CNAME for `registration` to use the new GuCDK-defined load balancer.

Additionally, swap the enablement status of the alarms:
- Disable the Low2XX alarms for the legacy load balancer
- Enable the Low2XX alarms for the new load balancer

Co-authored-by: Julia Branke <JuliaBrigitte@users.noreply.github.com>

Author: akash1810

cdk/lib/__snapshots__/registration.test.ts.snap

@@ -575,7 +575,7 @@ exports[`The Registration stack matches the snapshot for CODE 1`] = `
         "ResourceRecords": [
           {
             "Fn::GetAtt": [
-              "LoadBalancerToPrivateASG",
+              "LoadBalancerRegistration79F7817E",
               "DNSName",
             ],
           },
@@ -1174,7 +1174,7 @@ exports[`The Registration stack matches the snapshot for CODE 1`] = `
     },
     "Low2XXIn1dayE630C03B": {
       "Properties": {
-        "ActionsEnabled": false,
+        "ActionsEnabled": true,
         "AlarmActions": [
           {
             "Fn::Join": [
@@ -1250,7 +1250,7 @@ exports[`The Registration stack matches the snapshot for CODE 1`] = `
     },
     "Low2XXIn30minutesE2E53BDD": {
       "Properties": {
-        "ActionsEnabled": false,
+        "ActionsEnabled": true,
         "AlarmActions": [
           {
             "Fn::Join": [
@@ -1414,6 +1414,7 @@ exports[`The Registration stack matches the snapshot for CODE 1`] = `
     },
     "NotEnoughHttpCode200sAlarm": {
       "Properties": {
+        "ActionsEnabled": false,
         "AlarmActions": [
           {
             "Ref": "AlarmTopic",
@@ -1472,6 +1473,7 @@ exports[`The Registration stack matches the snapshot for CODE 1`] = `
     },
     "NotEnoughHttpCode200sPerDayAlarm": {
       "Properties": {
+        "ActionsEnabled": false,
         "AlarmActions": [
           {
             "Ref": "AlarmTopic",
@@ -2558,7 +2560,7 @@ exports[`The Registration stack matches the snapshot for PROD 1`] = `
         "ResourceRecords": [
           {
             "Fn::GetAtt": [
-              "LoadBalancerToPrivateASG",
+              "LoadBalancerRegistration79F7817E",
               "DNSName",
             ],
           },
@@ -3157,7 +3159,7 @@ exports[`The Registration stack matches the snapshot for PROD 1`] = `
     },
     "Low2XXIn1dayE630C03B": {
       "Properties": {
-        "ActionsEnabled": false,
+        "ActionsEnabled": true,
         "AlarmActions": [
           {
             "Fn::Join": [
@@ -3233,7 +3235,7 @@ exports[`The Registration stack matches the snapshot for PROD 1`] = `
     },
     "Low2XXIn30minutesE2E53BDD": {
       "Properties": {
-        "ActionsEnabled": false,
+        "ActionsEnabled": true,
         "AlarmActions": [
           {
             "Fn::Join": [
@@ -3397,6 +3399,7 @@ exports[`The Registration stack matches the snapshot for PROD 1`] = `
     },
     "NotEnoughHttpCode200sAlarm": {
       "Properties": {
+        "ActionsEnabled": false,
         "AlarmActions": [
           {
             "Ref": "AlarmTopic",
@@ -3455,6 +3458,7 @@ exports[`The Registration stack matches the snapshot for PROD 1`] = `
     },
     "NotEnoughHttpCode200sPerDayAlarm": {
       "Properties": {
+        "ActionsEnabled": false,
         "AlarmActions": [
           {
             "Ref": "AlarmTopic",

cdk/lib/registration.ts

@@ -18,7 +18,6 @@ import {
 	InstanceType,
 	SecurityGroup,
 } from 'aws-cdk-lib/aws-ec2';
-import type { CfnLoadBalancer } from 'aws-cdk-lib/aws-elasticloadbalancing';
 import { HttpCodeTarget } from 'aws-cdk-lib/aws-elasticloadbalancingv2';
 import { Topic } from 'aws-cdk-lib/aws-sns';
 import { CfnInclude } from 'aws-cdk-lib/cloudformation-include';
@@ -45,7 +44,7 @@ export class Registration extends GuStack {
 		// Until this project has been fully migrated to GuCDK you should update the 'old' infrastructure by modifying
 		// the YAML file and then re-running the snapshot tests to confirm that the changes are being pulled through by
 		// CDK
-		const template = new CfnInclude(this, 'YamlTemplate', {
+		new CfnInclude(this, 'YamlTemplate', {
 			templateFile: yamlTemplateFilePath,
 		});
 
@@ -154,7 +153,7 @@ export class Registration extends GuStack {
 					statistic: 'Sum',
 				})
 				.createAlarm(this, `Low2XXIn${humanPeriod}`, {
-					actionsEnabled: false,
+					actionsEnabled: true,
 					alarmDescription: `Triggers if load balancer in ${stage} does not have enough 200s in ${humanPeriod}. ${runbookCopy}`,
 					comparisonOperator: ComparisonOperator.LESS_THAN_THRESHOLD,
 					evaluationPeriods: 1,
@@ -168,17 +167,11 @@ export class Registration extends GuStack {
 
 		adjustCloudformationParameters(this);
 
-		const legacyLoadBalancer = template.getResource(
-			'LoadBalancerToPrivateASG',
-		) as CfnLoadBalancer;
-
 		// This CNAME represents the public URL for the registration service.
 		new GuCname(this, 'DnsRecordForRegistration', {
 			app,
 			domainName: props.domainName,
-			// For now we are still routing traffic to the legacy ELB.
-			// To complete the migration, we'll update to point at playApp.loadBalancer.loadBalancerDnsName.
-			resourceRecord: legacyLoadBalancer.attrDnsName,
+			resourceRecord: loadBalancer.loadBalancerDnsName,
 
 			// Intentionally low TTL for faster DNS changes
 			// TODO increase this to 7200 (2 hours) after the migration is complete

registration/conf/registration.yaml

@@ -309,6 +309,7 @@ Resources:
   NotEnoughHttpCode200sAlarm:
     Type: AWS::CloudWatch::Alarm
     Properties:
+      ActionsEnabled: FALSE
       AlarmActions: [!Ref AlarmTopic]
       OKActions: [!Ref AlarmTopic]
       AlarmDescription: !Sub Triggers if load balancer in ${Stage} does not have enough 200s in half an hour. ${RunbookCopy}
@@ -328,6 +329,7 @@ Resources:
   NotEnoughHttpCode200sPerDayAlarm:
     Type: AWS::CloudWatch::Alarm
     Properties:
+      ActionsEnabled: FALSE
       AlarmActions: [!Ref AlarmTopic]
       OKActions: [!Ref AlarmTopic]
       AlarmDescription: !Sub Triggers if load balancer in ${Stage} does not have enough 200s in a whole day. ${RunbookCopy}