Skip to content

Commit 2172a9c

Browse files
committed
Rename isEventLive field to isLive
1 parent 90132da commit 2172a9c

4 files changed

Lines changed: 14 additions & 14 deletions

File tree

liveactivities/src/main/scala/com/gu/liveactivities/BroadcastLambda.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ object BroadcastLambda extends RequestStreamHandler with Lambda with Logging {
7070
logger.error(s"Channel not active for match ID ${request.matchId}")
7171
Future.failed(new LiveActivityInvalidStateException(request.matchId, "Channel not active"))
7272
} else Future.successful(())
73-
_ <- if (!mapping.isEventLive) {
73+
_ <- if (!mapping.isLive) {
7474
logger.error(s"Event not live for match ID ${request.matchId}")
7575
Future.failed(new LiveActivityInvalidStateException(request.matchId, "Event not live"))
7676
} else Future.successful(())

liveactivities/src/main/scala/com/gu/liveactivities/models/LiveActivities.scala

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ case class LiveActivityMapping(
4242
id: String,
4343
channelId: String,
4444
isChannelActive: Boolean,
45-
isEventLive: Boolean,
45+
isLive: Boolean,
4646
data: Option[LiveActivityData],
4747
competitionId: Option[String],
4848
lastEventId: Option[String],
@@ -53,7 +53,7 @@ object LiveActivityMapping {
5353
(JsPath \ "id").read[String] and
5454
(JsPath \ "channelId").read[String] and
5555
(JsPath \ "isChannelActive").read[Boolean] and
56-
(JsPath \ "isEventLive").read[Boolean] and
56+
(JsPath \ "isLive").read[Boolean] and
5757
(JsPath \ "data").readNullable[LiveActivityData] and
5858
(JsPath \ "competitionId").readNullable[String] and
5959
(JsPath \ "lastEventId").readNullable[String] and
@@ -64,10 +64,10 @@ object LiveActivityMapping {
6464
(JsPath \ "id").write[String] and
6565
(JsPath \ "channelId").write[String] and
6666
(JsPath \ "isChannelActive").write[Boolean] and
67-
(JsPath \ "isEventLive").write[Boolean] and
67+
(JsPath \ "isLive").write[Boolean] and
6868
(JsPath \ "data").writeNullable[LiveActivityData] and
6969
(JsPath \ "competitionId").writeNullable[String] and
7070
(JsPath \ "lastEventId").writeNullable[String] and
7171
(JsPath \ "lastEventAt").writeNullable[String]
72-
)(r => (r.id, r.channelId, r.isChannelActive, r.isEventLive, r.data, r.competitionId, r.lastEventId, r.lastEventAt.map(dateTimeToString)))
72+
)(r => (r.id, r.channelId, r.isChannelActive, r.isLive, r.data, r.competitionId, r.lastEventId, r.lastEventAt.map(dateTimeToString)))
7373
}

liveactivities/src/main/scala/com/gu/liveactivities/service/LiveActivityChannelRepository.scala

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ trait ChannelMappingsRepository {
3535

3636
def updateMappingActiveChannel(id: String, isActive: Boolean): Future[Unit]
3737

38-
def updateMappingLiveEvent(id: String, isLive: Boolean): Future[Unit]
38+
def updateMappingSetLive(id: String, isLive: Boolean): Future[Unit]
3939

4040
def updateMappingLastEvent(id: String, lastEventId: Option[String], lastEventUpdate: Option[ZonedDateTime]): Future[Unit]
4141

@@ -88,7 +88,7 @@ class LiveActivityChannelRepository(client: DynamoDbAsyncClient, tableName: Stri
8888
id = id,
8989
channelId = channelId,
9090
isChannelActive = true,
91-
isEventLive = true,
91+
isLive = true,
9292
data = eventData,
9393
competitionId = competitionId,
9494
lastEventId = None,
@@ -113,11 +113,11 @@ class LiveActivityChannelRepository(client: DynamoDbAsyncClient, tableName: Stri
113113
private def updateMappingById(
114114
id: String,
115115
isChannelActive: Option[Boolean] = None,
116-
isEventLive: Option[Boolean] = None,
116+
isLive: Option[Boolean] = None,
117117
lastEventId: Option[String] = None,
118118
lastEventAt: Option[ZonedDateTime] = None
119119
): Future[Unit] = {
120-
if (Seq(isChannelActive, isEventLive, lastEventId, lastEventAt).forall(_.isEmpty)) {
120+
if (Seq(isChannelActive, isLive, lastEventId, lastEventAt).forall(_.isEmpty)) {
121121
logger.warn(s"No fields to update for live activity mapping with id $id")
122122
Future.successful(())
123123
} else {
@@ -131,7 +131,7 @@ class LiveActivityChannelRepository(client: DynamoDbAsyncClient, tableName: Stri
131131
.value(AttributeValue.fromBool(v))
132132
.build()
133133
},
134-
"isEventLive" -> isEventLive.map {v =>
134+
"isLive" -> isLive.map {v =>
135135
AttributeValueUpdate
136136
.builder()
137137
.action(AttributeAction.PUT)
@@ -176,11 +176,11 @@ class LiveActivityChannelRepository(client: DynamoDbAsyncClient, tableName: Stri
176176
}
177177

178178
override def updateMappingActiveChannel(id: String, isActive: Boolean): Future[Unit] = {
179-
updateMappingById(id, isChannelActive = Some(isActive), isEventLive = Some(isActive))
179+
updateMappingById(id, isChannelActive = Some(isActive), isLive = Some(isActive))
180180
}
181181

182-
override def updateMappingLiveEvent(id: String, isLive: Boolean): Future[Unit] = {
183-
updateMappingById(id, isEventLive = Some(isLive))
182+
override def updateMappingSetLive(id: String, isLive: Boolean): Future[Unit] = {
183+
updateMappingById(id, isLive = Some(isLive))
184184
}
185185

186186
override def updateMappingLastEvent(id: String, lastEventId: Option[String], lastEventAt: Option[ZonedDateTime]): Future[Unit] = {

liveactivities/src/test/scala/com/gu/liveactivities/LiveActivityChannelRepositorySpec.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ class LiveActivityChannelRepositoryTest(implicit ev: ExecutionEnv)
8888
id = "football-1234567",
8989
channelId = "test-channel-id",
9090
isChannelActive = true,
91-
isEventLive = true,
91+
isLive = true,
9292
data = Some(footballData),
9393
competitionId = Some("test-competition-id"),
9494
lastEventId = None,

0 commit comments

Comments
 (0)