Skip to content

Commit 508111a

Browse files
committed
chore(report): Detach GuardianAccessSecurityGroup security group from EC2 instances
The `GuardianAccessSecurityGroup` security group enables ingress on port 22. We've been using https://github.com/guardian/ssm-scala for a while, thus direct port 22 access is redundant. Removing security groups has an amount of orchestration: 1. Remove usage of the security group 2. Remove the security group This is part 1.
1 parent acdcf6b commit 508111a

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

report/conf/report.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,8 @@ Resources:
7676
- !GetAtt LoadBalancerToPrivateASG.DNSName
7777
TTL: 60
7878
Type: CNAME
79+
80+
# TODO remove this resource as it's redundant following adoption of https://github.com/guardian/ssm-scala.
7981
GuardianAccessSecurityGroup:
8082
Type: AWS::EC2::SecurityGroup
8183
Properties:
@@ -282,7 +284,6 @@ Resources:
282284
InstanceType: !FindInMap [StageVariables, !Ref Stage, InstanceType]
283285
SecurityGroups:
284286
- !Ref InstanceSecurityGroup
285-
- !Ref GuardianAccessSecurityGroup
286287
- !Ref VPCSecurityGroup
287288
MetadataOptions:
288289
HttpTokens: required

0 commit comments

Comments
 (0)