refactor(cdk): Adjust logging stream parameter within adjustCloudformationParameters

Updates the logic added in #1594 to also adjust the logging stream parameter.

Author: akash1810

cdk/lib/mobile-n10n-compatibility.ts

@@ -55,11 +55,32 @@ function adjustArtifactBucketParameter(stack: GuStack) {
 	);
 }
 
+/**
+ * In the Mobile account there are separate Kinesis streams for CODE and PROD, so we can't always use the account-wide default
+ */
+function adjustLoggingStreamParameter(stack: GuStack) {
+	if (stack.stage !== 'PROD') {
+		adjustParameter(
+			stack,
+			'/account/services/logging.stream.name',
+			'/account/services/logging.stream.name.code',
+		);
+	} else {
+		// Keep the same value, but explicitly set `allowedValues`
+		adjustParameter(
+			stack,
+			'/account/services/logging.stream.name',
+			'/account/services/logging.stream.name',
+		);
+	}
+}
+
 /**
  * Applications within the `mobile-n10n` stack do not use account (/GuCDK) defaults.
  * This adjusts CloudFormation parameters with values suitable for the `mobile-n10n` stack.
  */
 export function adjustCloudformationParameters(stack: GuStack) {
 	adjustVpcParameters(stack);
 	adjustArtifactBucketParameter(stack);
+	adjustLoggingStreamParameter(stack);
 }

cdk/lib/report.ts

@@ -2,7 +2,6 @@ import { GuPlayApp } from '@guardian/cdk';
 import { AccessScope } from '@guardian/cdk/lib/constants';
 import type { GuStackProps } from '@guardian/cdk/lib/constructs/core';
 import { GuVpcParameter } from '@guardian/cdk/lib/constructs/core';
-import { GuLoggingStreamNameParameter } from '@guardian/cdk/lib/constructs/core';
 import { GuStack } from '@guardian/cdk/lib/constructs/core';
 import { GuCname } from '@guardian/cdk/lib/constructs/dns';
 import { GuAllowPolicy } from '@guardian/cdk/lib/constructs/iam';
@@ -96,13 +95,6 @@ export class Report extends GuStack {
 
 		adjustCloudformationParameters(this);
 
-		// In the Mobile account there are separate Kinesis streams for CODE and PROD, so we can't use the account-wide
-		// default
-		const loggingStreamParameter =
-			GuLoggingStreamNameParameter.getInstance(this);
-		loggingStreamParameter.allowedValues = [props.loggingStreamParameterName];
-		loggingStreamParameter.default = props.loggingStreamParameterName;
-
 		new GuCname(this, 'DnsRecordForReport', {
 			app,
 			domainName: props.domainName,