Merge pull request #1567 from guardian/aa/rm-GuardianAccessSecurityGroup-take2

chore: Detach `GuardianAccessSecurityGroup` security group from EC2 instances

Author: akash1810

cdk/lib/__snapshots__/registration.test.ts.snap

@@ -814,9 +814,6 @@ exports[`The Registration stack matches the snapshot for CODE 1`] = `
           {
             "Ref": "InstanceSecurityGroup",
           },
-          {
-            "Ref": "GuardianAccessSecurityGroup",
-          },
           {
             "Ref": "VPCSecurityGroup",
           },
@@ -1691,9 +1688,6 @@ exports[`The Registration stack matches the snapshot for PROD 1`] = `
           {
             "Ref": "InstanceSecurityGroup",
           },
-          {
-            "Ref": "GuardianAccessSecurityGroup",
-          },
           {
             "Ref": "VPCSecurityGroup",
           },

registration/conf/registration.yaml

@@ -143,6 +143,8 @@ Resources:
       - !GetAtt LoadBalancerToPrivateASG.DNSName
       TTL: 60
       Type: CNAME
+
+  # TODO remove this resource as it's redundant following adoption of https://github.com/guardian/ssm-scala.
   GuardianAccessSecurityGroup:
     Type: AWS::EC2::SecurityGroup
     Properties:
@@ -290,7 +292,6 @@ Resources:
       InstanceType: !FindInMap [StageVariables, !Ref Stage, InstanceType]
       SecurityGroups:
       - !Ref InstanceSecurityGroup
-      - !Ref GuardianAccessSecurityGroup
       - !Ref VPCSecurityGroup
       MetadataOptions:
         HttpTokens: required

report/conf/report.yaml

@@ -76,6 +76,8 @@ Resources:
       - !GetAtt LoadBalancerToPrivateASG.DNSName
       TTL: 60
       Type: CNAME
+
+  # TODO remove this resource as it's redundant following adoption of https://github.com/guardian/ssm-scala.
   GuardianAccessSecurityGroup:
     Type: AWS::EC2::SecurityGroup
     Properties:
@@ -282,7 +284,6 @@ Resources:
       InstanceType: !FindInMap [StageVariables, !Ref Stage, InstanceType]
       SecurityGroups:
       - !Ref InstanceSecurityGroup
-      - !Ref GuardianAccessSecurityGroup
       - !Ref VPCSecurityGroup
       MetadataOptions:
         HttpTokens: required