better loging

Author: aracho1

common/src/main/scala/models/Registration.scala

@@ -18,18 +18,20 @@ object Registration {
     val base = Json.format[Registration]
     Format(
       Reads { json =>
-        (json \ "topics").asOpt[JsArray].foreach { arr =>
-          arr.value.foreach { v =>
+        val invalid = (json \ "topics").asOpt[JsArray].toSeq.flatMap { arr =>
+          arr.value.flatMap { v =>
             if (v.validate[Topic].isError) {
               val topicType = (v \ "type").asOpt[String].getOrElse("unknown")
               val topicName = (v \ "name").asOpt[String].getOrElse("unknown")
-              logger.warn(s"Invalid topic type=$topicType topic id=$topicName")
-            }
+              Some(s"Topic Type=$topicType (Topic Id=$topicName)")
+            } else None
           }
         }
+        if (invalid.nonEmpty)
+          logger.warn(s"Bad request: request contains invalid topic type(s). ${invalid.mkString(". ")}")
         base.reads(json)
       },
       base
     )
   }
-}
+}

registration/app/registration/CustomErrorHandler.scala

@@ -14,7 +14,8 @@ class CustomErrorHandler(env: Environment, config: Configuration, sourceMapper:
   private val logger: Logger = LoggerFactory.getLogger(this.getClass)
   override def onBadRequest(request: RequestHeader, message: String): Future[Result] = {
     val debugInfo = request.headers.get("User-Agent")
-    logger.error(s"Bad request due to $message. User agent = $debugInfo")
+    if (!message.startsWith("Json validation error"))
+      logger.error(s"Bad request due to $message. User agent = $debugInfo")
     Future.successful(BadRequest("Bad request"))
   }
 }